1
0
Fork 0
Commit Graph

556 Commits

Author SHA1 Message Date
Thaddeus Crews 1e63ed2a5b
Merge pull request #99723 from YeldhamDev/script_favorite_fix
Fix error when favoriting some types of properties
2024-12-30 08:58:34 -06:00
Michael Alexsander d74325f791
Fix error when favoriting some types of properties 2024-12-28 15:29:39 -03:00
A Thousand Ships a1846b27ea
Improve use of `Ref.is_null/valid`
Use `is_null` over `!is_valid` and vice versa.
2024-12-23 16:35:02 -05:00
Yufeng Ying f241c1fda0 Remove unused header in editor.
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
2024-12-24 00:40:38 +08:00
Pāvels Nadtočajevs 1e982a49c3 [Dictionary Property Editor] Use property editors instead of labels to display keys. 2024-12-18 08:14:38 +02:00
Haoyu Qiu bf4e5cca3f Make editor's shortcut names translated on-site 2024-12-18 13:00:30 +08:00
Thaddeus Crews 9c9af038d5
Merge pull request #91060 from dalexeev/code-edit-add-doc-tooltips
Code Editor: Add documentation tooltips
2024-12-16 12:09:45 -06:00
Danil Alexeev 80d11500b5
Code Editor: Add documentation tooltips 2024-12-15 10:51:33 +03:00
Aaron Franke 298daa8b6f
Expose EditorInspector.edit to scripting 2024-12-14 23:51:12 -08:00
Hilderin 4e19ab8afe
Fix connecting a signal with a double click is too difficult
Co-authored-by: Danil Alexeev <dalexeev12@yandex.ru>
2024-12-14 16:18:34 +03:00
Bastiaan Olij 0a61ebdcea OpenXR: Add support for binding modifiers 2024-12-12 09:46:19 +11:00
Thaddeus Crews b26f9f0380
Merge pull request #85275 from TheSofox/anchors-undo-fix
Correctly restore Control position on undoing an Anchors Preset
2024-12-10 14:15:47 -06:00
Thaddeus Crews 94711acfe1
Merge pull request #87375 from limbonaut/instantiate_property_editor
Export `EditorInspector::instantiate_property_editor` for use by plugins
2024-12-09 14:33:28 -06:00
Serhii Snitsaruk 803fa8f2e8
Export `EditorInspector::instantiate_property_editor` for use by plugins
And export useful properties and methods in the `EditorProperty` class.
2024-12-07 14:07:04 +01:00
Lukas Tenbrink b5c31ebb41 Add contains_char() for single-character 'contains' calls. 2024-12-06 20:23:35 +01:00
Hugo Locurcio e4106f8d61 Show String properties' text in a tooltip in the inspector
This allows previewing single-line or multipline strings
that are too long too fit within the box in the inspector.
2024-12-04 01:24:14 +01:00
A Thousand Ships af56d6e8e8
Use `SceneStringName` in more places 2024-12-02 14:39:16 +01:00
Rémi Verschelde 8d3fc48abf
Merge pull request #97521 from pafuent/enhance_scroll_container_focus
Add a focus border on `ScrollContainer`
2024-11-29 22:46:09 +01:00
Thaddeus Crews 7104f20634 Merge pull request #97986 from dustdfg/metadata/forbid_deleting_inherited_metadata
Editor: forbid deleting inherited metadata properties
2024-11-25 13:22:18 -06:00
Pablo Andres Fuente 86ea0127a3 Add a focus border on `ScrollContainer`
Also added new unit tests for `Control`.

Co-authored-by: ator-dev <dominic.codedeveloper@gmail.com>
2024-11-23 23:54:38 -03:00
jtcat bead829fd5 Fix inspector section iteration in `update_tree` 2024-11-22 15:15:31 +00:00
A Thousand Ships 68f638cf02
Use `(r)find_char` instead of `(r)find` for single characters 2024-11-17 10:02:18 +01:00
Christopher Briggs d1ba152197
Fix crash when inserting keyframes with empty properties array 2024-11-15 11:01:34 +01:00
Thaddeus Crews ed3de25a9a
Merge pull request #97415 from YeldhamDev/i_love_all_my_properties_equally
Make possible to favorite properties in the inspector
2024-11-11 14:17:57 -06:00
Aaron Franke 562c666e3d
Rename internal Button icon to button_icon to match exposed methods 2024-10-29 16:23:03 -07:00
Michael Alexsander d678b095f9
Make possible to favorite properties in the inspector 2024-10-28 21:18:21 -03:00
Yevhen Babiichuk (DustDFG) edde380e9c Editor: forbid deleting inherited metadata properties
Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
Co-authored-by: Tomek <kobewi4e@gmail.com>
2024-10-19 09:51:12 +03:00
Rémi Verschelde 60708ccbfe
Merge pull request #96542 from Maran23/inspector-scrolls-away
Fix Inspector may scroll away when editing a property that adds or removes sub properties
2024-10-01 17:30:45 +02:00
Haoyu Qiu 14321b8ed5 Set auto translate mode for drag previews
- Controls
  - `LineEdit`, `TextEdit`: Always disabled since it's dragging user input.
  - `TabBar`: Use the same auto translate mode as the node.
  - `RichTextLabel`: Always disable since auto translation is done
    differently from other controls (selection text you get
    programmatically is always after auto translation).
- Editor
  - Disable drag preview auto translation if the text is user input,
    filename, or class name.
  - Also disabled unexpected auto translation for audio bus effect names.
2024-09-19 19:21:29 +08:00
demolke 0468bea899 Add per-bone meta to Skeleton3D
Individual bones are not represented as `Node`s in Godot, in order to support meta functionality for them the skeleton has to carry the information similarly to how other per-bone properties are handled.
- Also adds support for GLTF import/export
2024-09-16 16:26:15 +02:00
Stuart Carnie 5cfacc8767
[Editor,Servers]: Minor optimizations 2024-09-12 06:22:04 +10:00
kit 5e1c9d68aa Extract editor main screen 2024-09-09 11:06:18 -04:00
Rémi Verschelde 7f6e1693dd
Merge pull request #92407 from timothyqiu/section-dropping
Remove unused member variable in `EditorInspectorSection`
2024-09-04 11:16:28 +02:00
Marius Hanl 27b7b433e0 Fix Inspector may scrolls away when editing a property that adds or removes sub properties 2024-09-04 01:20:11 +02:00
Haoyu Qiu 8bf4ecc026 Add `String.is_valid_unicode_identifier()`
- Adds `is_valid_unicode_identifier()`
- Adds `is_valid_ascii_identifier()`
- Deprecates `is_valid_identifier()`
- Renames `validate_identifier()` to `validate_ascii_identifier()`
2024-08-27 11:34:08 +08:00
Aaron Franke 2e7526af42
Fix editor inspector crashing when the old object is no longer valid 2024-07-08 14:00:28 -07:00
Rémi Verschelde d119e49902
Merge pull request #93627 from passivestar/inspector-unused-vboxes
Hide unused category vboxes in inspector
2024-06-26 18:15:24 +02:00
passivestar 025159f57e Hide unused category vboxes in inspector 2024-06-26 16:02:22 +04:00
kobewi f0da5cac7b Always call _can_handle() before _parse_property() 2024-06-26 13:10:08 +02:00
passivestar 6bb58ca5ae Make inspector spacing more themable 2024-06-22 19:55:47 +04:00
Yuri Rubinsky 89dd7107d9 Fix theme updating of the inspector sections 2024-06-19 19:37:59 +03:00
A Thousand Ships fbb879debd
[Scene] Add `SceneStringNames::text/value_changed` 2024-06-19 09:44:38 +02:00
A Thousand Ships ca18a06ecb
[Scene] Add `SceneStringNames::confirmed` 2024-06-19 09:40:54 +02:00
A Thousand Ships d519715d94
[Scene] Add `SceneStringNames::font(_size/_color)` 2024-06-18 17:24:27 +02:00
passivestar 2cd0f3584d Fix EditorProperty spacing 2024-06-12 18:02:24 +04:00
Valentin Cocaud c31111f5ec Editor: Focus value editor on type change in Dictionary and Array editors 2024-06-04 16:51:29 +02:00
kobewi be111004dd Fix default NodePaths saved in scene 2024-06-03 13:10:23 +02:00
A Thousand Ships 926afccbd8
[Scene] Add `SceneStringNames::panel` 2024-05-30 22:54:50 +02:00
A Thousand Ships 755a0efbb6
[Scene] Add `SceneStringNames::id_pressed` 2024-05-30 22:54:04 +02:00
Michael Alexsander 1bfcb6ee65
Set `doc_name` even when categories are hidden in the inspector
Otherwise, tooltips will fail to fetch descriptions.
2024-05-28 15:44:22 -03:00
Haoyu Qiu d35053056e Remove unused member variable in EditorInspectorSection 2024-05-27 08:10:51 +08:00
Gilles Roudière 85eac45513 Display custom data name instead of indices in TileData inspector 2024-05-25 17:21:31 +02:00
Michael Alexsander e1798f4278
Fix unchecking theme overrides not creating an undo action 2024-05-22 21:24:31 -03:00
kobewi ba96affd6c Disable follow focus while updating inspector 2024-05-19 12:44:30 +02:00
A Thousand Ships ee79386f7b
[Scene] Add SceneStringNames::pressed 2024-05-14 15:51:28 +02:00
Rémi Verschelde 3c26cddcfa
Merge pull request #91932 from dalexeev/editor-fix-tileset-categories-and-tooltips
Editor: Fix categories and tooltips in `TileSet` editor
2024-05-14 12:07:27 +02:00
Danil Alexeev 5a5b18c2fc
Editor: Fix categories and tooltips in `TileSet` editor 2024-05-14 10:23:14 +03:00
kobewi 413c11357d Use Core/Scene stringnames consistently 2024-05-13 23:41:07 +02:00
ajreckof 114ab9dd04 fix infinite call loop on theme change.
Apply suggestions from code review
2024-05-13 14:39:02 +02:00
Haoyu Qiu fe1bf76e6f Fix long category name display in Inspector 2024-05-11 09:51:32 +08:00
A Thousand Ships b4c6cc7d82
[Core] Add case-insensitive `String::containsn` 2024-05-08 12:48:01 +02:00
kobewi 5c28814b39 Add as_sortable_control() to unify Container checks 2024-05-08 11:45:52 +02:00
Rémi Verschelde 25324545f2
Merge pull request #91538 from kitbdev/fix-inspector-exit-crash
Fix EditorInspector crash when exiting
2024-05-07 16:49:46 +02:00
A Thousand Ships 955d5affa8
Reduce and prevent unnecessary random-access to `List`
Random-access access to `List` when iterating is `O(n^2)` (`O(n)` when
accessing a single element)

* Removed subscript operator, in favor of a more explicit `get`
* Added conversion from `Iterator` to `ConstIterator`
* Remade existing operations into other solutions when applicable
2024-05-04 16:08:55 +02:00
kit 55afb5b680 Fix EditorInspector crash when exiting 2024-05-03 16:27:59 -04:00
ajreckof cba9606611 Add colored margin in Inspector for arrays and dictionaries.
Apply suggestions from code review

Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-Authored-By: Tomek <kobewi4e@gmail.com>
2024-05-03 10:56:23 +02:00
Rémi Verschelde bf00e1efde
Merge pull request #91168 from kitbdev/docks-dont-edit-current-v2
Don't edit current when changing docks v2
2024-04-30 17:03:25 +02:00
Magian e3a7c751f2 Implement tooltips for shader uniform in the inspector.
using regular expressions
2024-04-26 17:48:11 +08:00
kit eefd311456 Don't edit current when changing docks v2 2024-04-25 15:01:20 -04:00
Rémi Verschelde 2ad43045a3
Revert "Don't edit current when changing docks"
This reverts commit 55711b2ee8.
Fixes #91046.
2024-04-23 19:08:16 +02:00
Rémi Verschelde 8ab5ab19c3
Merge pull request #90816 from kitbdev/dock-dont-edit-current
Don't edit current when changing docks
2024-04-22 12:53:00 +02:00
kit 55711b2ee8 Don't edit current when changing docks 2024-04-19 17:10:38 -04:00
Danil Alexeev a714cb9f65
Editor: Display deprecated/experimental messages in tooltips 2024-04-18 14:32:04 +03:00
aaronp64 050ca0c5ed Fix theme_override tooltip caching
theme_override properties have some special handling in EditorInspector.  When caching documentation info for properties, the theme_item_name value (used only for theme_overrides) was not being cached, so it would only be included on first use.  This meant that theme_override property tooltips would show up in the editor the first time a node was selected, but not again after selecting something else/reselecting.  Added theme_item_name to caching to fix this.

Fixes #90395
2024-04-09 14:31:44 -04:00
Haoyu Qiu 479b7afa8e Add context support for editor property name i18n 2024-03-31 18:40:14 +08:00
Sofox 785b8a6c92 Undoing an Anchor Preset on a Control will correctly restore its position 2024-03-29 18:38:54 +00:00
Rémi Verschelde c9c0205c07
Merge pull request #89631 from dalexeev/editor-fix-inspector-groups-interfering
Editor: Fix same-name (sub)groups interfering in Inspector
2024-03-24 01:20:02 +01:00
A Thousand Ships 79ba22a73f
Use `Vector*` component-wise `min/max/clamp` functions where applicable 2024-03-20 13:47:42 +01:00
Danil Alexeev 9b7dcfa0e2
Editor: Fix same-name (sub)groups interfering in Inspector
Clear (sub)group hashmaps when changing category.
2024-03-18 09:49:21 +03:00
kobewi 7319b612f3 Speed up inspector updates for TileMap 2024-03-07 18:01:30 +01:00
Hendrik Brucker d32e0f808c Make editing properties more intuitive in VisualShader 2024-03-05 13:27:33 +01:00
Muller-Castro 1638c1b28f Add const lvalue ref to editor/* container parameters 2024-02-26 15:28:15 -03:00
RedMser 7a08b1fcd6 Inspector changes indicator propagates upwards 2024-02-25 21:12:17 +01:00
Rémi Verschelde 6037500219
Merge pull request #69032 from KoBeWi/check_every_changed_setting_in_every_group_everywhere()
Use `check_changed_settings_in_group()` everywhere
2024-02-20 19:34:30 +01:00
kobewi c060ff8b41 Remove error when property is outside inspector 2024-02-20 14:53:16 +01:00
kobewi a031911c82 Use check_changed_settings_in_group() everywhere 2024-02-19 21:34:45 +01:00
Rémi Verschelde 92fcbe2f5c
Revert "Allow configuration warnings to refer to a property"
This reverts commit bf37a9bac6.
2024-02-17 19:04:18 +01:00
Rémi Verschelde 9f76398781
Revert "Only update inspector if configuration warning change relevant"
This reverts commit a53793472e.
2024-02-17 19:00:04 +01:00
Danil Alexeev b2f62658a2
Editor: Fix skipping normal category followed by custom one 2024-02-14 11:28:53 +03:00
Rémi Verschelde 85869957e9
Merge pull request #88182 from RedMser/fix-88176-inspector
Only update inspector if configuration warning change was relevant
2024-02-13 23:43:37 +01:00
Rémi Verschelde 391a8e5327
Merge pull request #85868 from KoBeWi/knowyourtiles
Add descriptions for tile properties
2024-02-13 11:24:42 +01:00
RedMser a53793472e Only update inspector if configuration warning change relevant
Fixes #88176
2024-02-10 20:46:09 +01:00
A Thousand Ships 684752e75b
Replace error checks against `size` with `is_empty` 2024-02-09 12:50:15 +01:00
RedMser bf37a9bac6 Allow configuration warnings to refer to a property
This is used by the inspector so it can show a warning icon on
a specific property.
2024-02-08 23:05:20 +01:00
Danil Alexeev 547f03b6d7
Editor: Fix `_parse_category()` is not called for custom categories 2024-02-03 23:54:32 +03:00
Rémi Verschelde fa48a51183
Merge pull request #87688 from AThousandShips/what_is_this
Remove unnecessary `this->` expressions
2024-01-29 13:18:09 +01:00
Yuri Sizov d644b9b640 Better hide internal properties from users 2024-01-29 12:35:10 +01:00
A Thousand Ships 15369fdb1d
Remove unnecessary `this->` expressions 2024-01-29 09:59:18 +01:00
Yuri Sizov 635b8a1474 Split theme generation logic into several subroutines
This change introduces a new theme configuration struct to be
passed to the aforementioned routines to better control reuse
of styles and definitions in the generator.

Everything not passed and not explicitly shared is scoped so it
is not automatically accessible throughout the routine. This
should ensure that the decision to share styles is a conscious one.

In the future we will try to reduce the number of unique definitions
and share most of it. This PR is a stepping stone on this path.

This also puts the effort into separating redefinitions of
default theme items vs custom types introduced only by the editor.
In a few cases where editor-specific definitions need to reference
default definitions we simply fetch them from the theme. It's not
ideal and hides the dependency a bit, but hopefully these cases
will be abstracted properly in due time.
2024-01-16 11:57:45 +01:00
Yuri Sizov 95b27fe8c7 Reorganize code related to editor theming
This change introduces a new EditorThemeManager class
to abstract theme generatio and its subroutines.

Logic related to EditorTheme, EditorColorMap, and editor
icons has been extracted into their respective files with
includes cleaned up.

All related files have been moved to a separate folder to
better scope them in the project. This includes relevant
generated files as well.
2024-01-16 11:57:45 +01:00