f47f4a02c8
Merge pull request #89992 from ajreckof/fix-my-mistake-with-replace-in-update-scene
...
Fix node duplication in update after external changes.
2024-04-04 02:53:57 +02:00
ae472865d0
fix node duplication in update after external changes.
2024-04-03 12:19:38 +02:00
af08342fd8
Merge pull request #89957 from warriormaster12/regress-dup
...
Fix regression when duplicating a node with a resource attached
2024-03-28 10:47:39 +01:00
9533543aa5
Fix duplicating resources regression
2024-03-27 11:51:29 +02:00
9d8697ab01
Merge pull request #89686 from kleonc/unique-node-names-check-owned-then-in-owner
...
Always look for unique node names in owner if not found in owned nodes
2024-03-24 01:21:28 +01:00
1d4907243e
Merge pull request #89628 from twobitadder/whoops_no_internals_pls
...
Fix crash on `reparent()` with Node containing internal children
2024-03-24 01:19:34 +01:00
e92806c7e7
Merge pull request #88424 from rburing/fti_2d
...
Physics interpolation (2D)
2024-03-24 01:13:53 +01:00
2ed2ccc2d8
Fixed Timestep Interpolation (2D)
...
Adds fixed timestep interpolation to the rendering server (2D only).
Switchable on and off with a project setting (default is off).
Co-authored-by: lawnjelly <lawnjelly@gmail.com>
2024-03-23 12:28:36 +01:00
95ced4bbdc
Always look for unique node names in owner if not found in owned nodes
2024-03-19 22:13:10 +01:00
b9bade8db1
fixes crash on nodes with internal children
2024-03-17 22:44:05 -04:00
9851c1bdd8
Fix property duplication when duplicating a parent node
2024-03-17 09:57:38 +02:00
c1377920cd
Merge pull request #86743 from Mickeon/autocompletion-optimise-object
...
Optimise comparisons for Object's `get_argument_options`
2024-03-01 14:56:06 +01:00
cd2032a90b
Optimise Object's `get_argument_options`
2024-02-29 18:00:54 +01:00
c58607c32f
Fix owner when importing meshes
...
Handle the case correctly, that a child of a replaced node has
as owner an ancestor of the replaced node.
2024-02-26 22:24:57 +01:00
75ba837612
Fix inefficient list iteration in Node
2024-02-24 23:18:44 +01:00
ae97cf2ff0
Fix AnimationMixer breaking animations with redundant check
...
Also change `Node::get_node_and_resource` to prevent it from printing an
error from `Node::get_node`, and just returns nullptr. This is what the
redundant check was trying to prevent.
Fixes #88428 .
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2024-02-19 16:50:19 +01:00
ab4c5a594a
Merge pull request #88521 from YeldhamDev/atr_regression
...
Fix regression in auto translation overhaul
2024-02-19 00:09:22 +01:00
0f0515a75f
Merge pull request #87743 from WhalesState/camera2d
...
Fix `Camera2D` is enabled when dragging scene files to the `CanvasItemEditor`
2024-02-19 00:07:57 +01:00
b56774b5bf
Fix regression in auto translation overhaul
2024-02-18 19:33:08 -03:00
451b198c40
Fix dragging scene files to the `CanvasItemEditor`
2024-02-18 21:55:14 +02:00
92fcbe2f5c
Revert "Allow configuration warnings to refer to a property"
...
This reverts commit bf37a9bac6
2024-02-17 19:04:18 +01:00
7b42c24550
Make auto translation inheritable
2024-02-15 16:51:19 -03:00
58a8eb8617
Merge pull request #84824 from Rindbee/fix-double-internal-node
...
Fix duplicating sub-scene may get two copies of internal node
2024-02-09 12:14:29 +01:00
bf37a9bac6
Allow configuration warnings to refer to a property
...
This is used by the inspector so it can show a warning icon on
a specific property.
2024-02-08 23:05:20 +01:00
0de8a736da
Allow Node.create_tween() outside SceneTree
2024-01-29 20:18:43 +01:00
ef9cb3dfa5
Merge pull request #87535 from Mickeon/scene-tree-configuration-warnings-cleanup
...
Improve appearance of Node configuration warnings
2024-01-29 13:17:17 +01:00
3e4e0f08c4
Improve appearance of Node configuration warnings
2024-01-27 13:03:07 +01:00
adcfe3d1a0
Merge pull request #87252 from ajreckof/Fix-renaming-a-node-to-the-name-of-its-siblings-breaking-NodePath
...
Fix renaming a node to the name of its siblings breaking NodePath
2024-01-24 14:08:20 +01:00
28cf7fe2f6
Merge pull request #85384 from HolonProduction/unique-name-completion
...
Suggest scene unique nodes in `get_node` autocompletion
2024-01-17 18:52:31 +01:00
2f697926b0
Fix renaming a node to the name of its siblings breaking NodePath
...
Also fix cases where node name was not visually updated because name was not changed
Co-Authored-By: Nông Văn Tình <53887662+nongvantinh@users.noreply.github.com>
2024-01-16 15:18:30 +01:00
f3fc35eb17
Merge pull request #81506 from twobitadder/reparent_keep_owner
...
Fix `reparent()` losing owner
2024-01-11 17:34:19 +01:00
f996003fb4
Add autocompletion to `get_node_or_null`
2024-01-06 17:33:32 +01:00
fbaab3cf53
Merge pull request #86745 from KoBeWi/internal_error
...
Ignore internal children when replacing node
2024-01-03 15:48:41 +01:00
73c5deff76
Merge pull request #82916 from jsjtxietian/update-scene-tree-tooltip-after-editor-description-chnage
...
Support updating tooltip immediately after editor description change
2024-01-03 15:41:31 +01:00
cd2edfef25
Ignore internal children when replacing node
2024-01-03 13:04:16 +01:00
f19c419126
Fix duplicating sub-scene may get two copies of internal node
...
Previously, internal node might be mistaken for `hidden_root` and be duplicated again.
Exclude those internal nodes to avoid this case, unless the owner is set intentionally.
2023-12-20 18:29:25 +08:00
958699a0c4
Implement project-wide node groups
2023-12-19 18:07:19 +01:00
13305d31b5
Merge pull request #83343 from warriormaster12/node-property-duplication
...
Fix export variable of type Node pointing to a wrong child node when duplicating
2023-12-08 15:22:59 +01:00
8cc85515af
Suggest scene unique nodes in `get_node` autocompletion
2023-11-26 15:41:29 +01:00
d3d00c7039
Fix crash caused by stale owner
...
Adjust `NOTIFICATION_PREDELETE` in `Node` to clean up owned nodes.
Also print a warning, when the owner becomes invalid.
2023-11-17 19:53:58 +01:00
4680ced5fa
support updating tooltip after editor description change
2023-11-15 14:27:49 +08:00
15b8185c68
Don't use TTR/RTR for ERR/WARN prints
...
We don't translate those, only editor strings are translated.
2023-11-12 12:00:55 +01:00
623b905d2e
Remove unused `NOTIFICATION_NODE_RECACHE_REQUESTED` notification
2023-11-06 12:16:32 +01:00
de1dc6c8d4
Fix node property duplication
2023-11-04 10:45:38 +02:00
b4aa6ad36e
Fix `reparent` losing owner if relationship to original owner is not broken
2023-10-26 13:08:05 -04:00
034c0f1624
Replace `sanity` with `safety` for checks
2023-10-08 16:22:24 +02:00
3b70e30e9b
Merge pull request #77072 from vPumpking/get-tree-string
...
Add `Node.get_tree_string` and `Node.get_tree_string_pretty`
2023-10-05 16:32:12 +02:00
aff767ef07
Fix expected argument count for `Callable` call errors
2023-09-29 20:00:10 +03:00
e36117f557
Fix can not set process priority of node if not any process is processing
2023-09-26 19:29:25 +08:00
bd575c5fe5
Add 'get_tree_string()' and 'get_tree_string_pretty()' to Node class to complement printing methods
2023-09-15 19:18:53 +02:00
d8ff69d53c
Extract ScriptInstance to simplify includes
...
This allows to include script_instance.h directly in the
generated gdvirtual.gen.inc, and remove excessive includes
from the codebase.
This should also allow Resource to use GDVIRTUAL macros,
which wasn't possible previously due to a circular dependency.
2023-09-06 22:54:38 +02:00
9cf13cedfd
Ensure binds are duplicated with `Node` signals
2023-08-29 16:52:38 +02:00
c081d1bd24
Merge pull request #78816 from kleonc/scene-tree-fix-drag-drop-to-parent-with-internal-nodes
...
Fix drag-dropping nodes to parent with internal nodes
2023-08-16 16:54:06 +02:00
fd1ee5d56b
Merge pull request #79332 from AThousandShips/mp_crash
...
Prevent crash when accessing `Node` Multiplayer from thread
2023-08-01 17:25:07 +02:00
4d42d6fdf6
Merge pull request #78706 from RedworkDE/node-rename-inplace
...
Allow renaming child nodes in `_ready`
2023-07-21 17:15:26 +02:00
7bd3a3a5e5
Prevent crash when accessing `Node` Multiplayer from thread
2023-07-11 12:57:25 +02:00
6cb1162aa0
Merge pull request #79000 from AThousandShips/owner_error
...
Improve error message for `Node.set_owner`
2023-07-11 11:29:30 +02:00
3f6e35bdb2
Fix drag-dropping nodes to parent with internal nodes
2023-07-07 19:24:44 +02:00
0183340012
Improve error message for `Node.set_owner`
2023-07-04 08:51:12 +02:00
b02dff6e1c
Fix `Node::add_sibling` parent check
...
Replace `data.blocked > 0` by `data.parent->data.blocked > 0` in order
to check if the parent is busy.
2023-06-29 20:21:37 +02:00
70ca659143
Fix node internal/non-internal processing order
...
Bonus:
Fix issues in group-processing related setters
2023-06-27 19:19:55 +02:00
2c0caa5828
Allow renaming child nodes in `_ready`
2023-06-26 13:25:48 +02:00
31fab43b8b
Fix scene load crash related to `_ready`
...
The iterator might get invalidated during `_ready`-user-code.
Prevent this by disallowing set_name during iterator-operations.
2023-06-25 22:35:38 +02:00
cce100a840
Merge pull request #75459 from kleonc/node-fix-find-children
...
Fix recursive `Node.find_children`
2023-06-19 22:33:46 +02:00
eb391d3302
Display `BitField[Enum]` in docs to distinguish from `Enum`
2023-06-15 17:23:02 +03:00
c3e5e4ed4b
Merge pull request #68599 from Rindbee/update-edited_scene_root-in-time
...
Update the edit scene root in time after it is replaced
2023-06-12 17:08:50 +02:00
eb74079dfb
Update the edit scene root in time after it is replaced
...
When changing the type of the edited scene root node, it may be necessary
to update edited scene root in time for the child nodes to work properly.
2023-06-12 21:49:30 +08:00
dcd2b883eb
Use NULL instead of COND checks when appropriate
...
Restricted to scene
2023-06-10 08:56:30 +02:00
7561e176e8
Fix parent inconsistency in `Node::remove_child`
...
`NOTIFICATION_CHILD_ORDER_CHANGED` could be triggered, while there
was an inconsistent state:
- parent node no longer had child listed as child
- child node still had parent node listed as parent
Bring these two in sync, before emitting the notification.
2023-06-08 22:51:07 +02:00
bd468cdec7
Display the node path or name in Node thread guard errors
...
This makes it easier to diagnose which node is the source of the issue.
2023-06-07 16:06:53 +02:00
15ee292664
Don't update mouse cursor state on child order changed
...
Partially Revert "Create a virtual mouse move event after moving child nodes"
This reverts parts of commit ce10ca6979
2023-06-05 10:28:55 +02:00
ce10ca6979
Create a virtual mouse move event after moving child nodes
...
This updates mouse cursor and mouse-over-states without the need
for additional mouse movements.
2023-05-29 22:46:19 +02:00
508a5bf16e
Merge pull request #76025 from YuriSizov/editor-reparentable-windows
...
Expose dialog parent-and-popup logic to the API
2023-05-16 10:49:09 +02:00
8cfa19a078
Merge pull request #77000 from reduz/make-more-base-nodes-thread-safe
...
Make more base nodes thread safe
2023-05-16 00:31:56 +02:00
17f492fb82
Expose dialog parent-and-popup logic to the API
2023-05-15 19:49:28 +02:00
0a9f72d5a8
Make more base nodes thread safe
...
Ongoing work to make more of the base nodes thread safe.
2023-05-15 16:54:10 +02:00
1eb250e17d
Avoid crash when adjusting a node tree that is not in the tree
...
When node tree `A` is not in the tree, `remove_child(B)` will not
automatically clean up the owners of `B` and `B`'s child nodes.
This is convenient for implementing operations like `replace_by()`,
but may have hidden dangers when manipulating the rest of the tree
`A`.
This commit makes it safe to manipulate the rest of `A` after freeing
`B`.
2023-05-11 08:57:39 +08:00
98c655ec8d
Refactor Node Processing
...
* Node processing works on the concept of process groups.
* A node group can be inherited, run on main thread, or a sub-thread.
* Groups can be ordered.
* Process priority is now present for physics.
This is the first steps towards implementing https://github.com/godotengine/godot-proposals/issues/6424 .
No threading or thread guards exist yet in most of the scene code other than Node. That will have to be added later.
2023-05-09 19:17:51 +02:00
1b9802fa8c
Prevent errors when using ViewportTexture
2023-05-08 15:56:16 +02:00
6aac8af6f1
Merge pull request #69318 from Sauermann/fix-refresh-gui-events
...
Fix scene reload crash related to mouse cursor update
2023-04-25 15:36:26 +02:00
8eb9986dc5
Make `Node::get_children()` public
2023-04-15 21:59:25 -05:00
d159123633
Fix recursive Node.find_children
2023-04-09 09:15:21 +02:00
ab5fc22f67
Optimize Node children management
...
* Adding and removing child nodes is now constant time, speed up should be huge.
* Searching for node paths as in ("path/to/node") should be far faster too.
This changes the children management and makes it a hashmap, optimizing most StringName based operations.
Most operations should be severe speed up without breaking compatibility.
This should fix many issues regarding to node access performance, and may also speed up editor start/end, but benchmarks are needed. So if you want to test, please make some benchmarks!
Further performance improvements will be done in the future by removing NOTIFICATION_MOVED_IN_PARENT and replacing by something less laborious.
2023-04-08 10:54:28 +02:00
c151d3231f
Merge pull request #75760 from reduz/optimize-node-add-child-validation
...
Optimize Node::add_child validation
2023-04-07 18:20:28 +02:00
223ce4fcb9
Optimize Node::add_child validation
...
Adding 10k nodes is almost twice as fast.
2023-04-07 13:18:47 +02:00
404f24b5c4
Update sibling indices after a node is removed.
...
With change 104392e
2023-04-06 20:47:57 +02:00
104392ef4e
Remove NOTIFICATION_MOVED_IN_PARENT
...
* This notification makes node children management very inefficient.
* Replaced by a NOTIFICATION_CHILDREN_CHANGED (and children_changed signal).
* Changed Canvas code (and similar) to use the above signal, to perform more efficiently.
This PR breaks compatibility (although this notification was very rarely used, even within the engine), but provides an alternate way to do the same.
It is required for the changes in #75627 to be entirely effective.
2023-04-06 13:57:13 +02:00
8f8178bda6
Fix auto-translations in editor
2023-03-22 23:57:12 +01:00
81e2b020ba
Prevent infinite loops when printing orphan nodes
2023-03-09 16:47:38 +01:00
5bb66d3cfb
Fix scene reload crash caused by mouse cursor update
...
After a scene reload a mouse cursor updates is performed via a
InputEventMouseMotion, that is exposed to the user.
The state of Input is however not adjusted to this InputEventMouseMotion
which can lead to inconsistencies.
This PR makes sure, that it is not exposed to the user.
It utilizes the method of Viewport::_process_picking for marking
events that are not sent to the user, so that this function doesn't
need to be changed.
2023-02-10 01:16:23 +01:00
e52213e2fa
More codespell fixes, do more changes from previous ignore list
2023-02-01 12:11:36 +01:00
9f026d5274
Fix Editor Description tooltip not changing until scene is reopened
...
You still need to select another node to see the tooltip updated first,
but you no longer need to save and reopen the scene to view the updated
tooltip.
2023-01-30 00:18:13 +01:00
2bc0bcbd26
PropertyUsage: Rename "DO_NOT_SHARE_ON_DUPLICATE" to "ALWAYS_DUPLICATE"
2023-01-24 16:05:07 -06:00
fab9926a95
Merge pull request #65137 from dalexeev/editor-naming
...
Rearrange `editor/naming/*` project settings
2023-01-24 22:26:03 +03:00
11e2278844
Merge pull request #57606 from SaracenOne/update_on_reimport
...
Update instances of scenes which have been reimported.
2023-01-23 15:35:44 +01:00
7b622ce6e8
Merge pull request #71021 from reduz/prevent-physics-callback-removal
...
Error when removing a physics node during a physics callback
2023-01-21 11:28:02 +01:00
4628736894
Update instances of scenes which have been reimported.
2023-01-16 13:46:33 -08:00
8f706be6fa
Rearrange `editor/naming/*` project settings
2023-01-12 11:41:13 +03:00
ca8b762797
Add Node::get_window() method.
2023-01-10 11:10:46 +02:00
3579d7a9f7
Merge pull request #36301 from KoBeWi/daddy_node
...
Add reparent methods to Node
2023-01-07 13:20:56 +01:00
Rémi Verschelde
ajreckof
Rémi Verschelde
warriormaster12
Ricardo Buring
kleonc
twobit
Micky
Markus Sauermann
kobewi
Travis Lange
Michael Alexsander
Mounir Tohami
RedMser
Yuri Sizov
风青山
Stanislav Labzyuk
HolonProduction
jsjtxietian
A Thousand Ships
Danil Alexeev
vPumpking
Ninni Pipping
Pedro J. Estébanez
RedworkDE
Hugo Locurcio
Juan Linietsky
Aaron Franke
Samuele Panzeri
Yuri Sizov
SaracenOne
bruvzg