mirror of https://github.com/godotengine/godot
cccd2432c3
In order to make CommandQueueMT more maintainable this PR changes the previous macro hell with variadic templates instead. This makes the class far more explicit and will allow us to more easily change the way the class functions in the future. Furthermore this refactoring has allowed for some optimizations. In particular by using std::forward to delay the decision of decaying the type to as late as possible we are able to move the data from the callsite into our Command buffer and later move it to the call. In practice what this means is that compared to the old version instead of copying values 3 times, we can now get away with 1 copy, and 1 move for lvalues, and just 2 moves for rvalues. This saves quite a few operations in a hot codepath. We also now test to make sure that the amount of copies and moves are what we expect. This way we can spot performance regressions in this code easily. Somewhat unscientifically, running TPS-demo by pressing enter and not touching the controls average mspf, repeatable across many runs: before: 6.467 after : 6.202 |
||
|---|---|---|
| .. | ||
| config | ||
| crypto | ||
| debugger | ||
| error | ||
| extension | ||
| input | ||
| io | ||
| math | ||
| object | ||
| os | ||
| string | ||
| templates | ||
| variant | ||
| SCsub | ||
| core_bind.compat.inc | ||
| core_bind.cpp | ||
| core_bind.h | ||
| core_builders.py | ||
| core_constants.cpp | ||
| core_constants.h | ||
| core_globals.cpp | ||
| core_globals.h | ||
| core_string_names.h | ||
| doc_data.cpp | ||
| doc_data.h | ||
| register_core_types.cpp | ||
| register_core_types.h | ||
| typedefs.h | ||
| version.h | ||