1
0
Fork 0
godot/servers/rendering/renderer_rd
Matias N. Goldberg b9a2f108fc Fix splash screen upside down on Android
Fixes an issue introduced in #96439 (see
https://github.com/godotengine/godot/pull/96439#issuecomment-2447288702)

Godot was relying on Java's
activity.getWindowManager().getDefaultDisplay().getRotation(); to apply
pre-rotation but this is wrong.

First, getRotation() may temporarily return a different value from the
correct one; which is what was causing the splash screen to be upside
down. It would return -90 instead of 90 for the first rendered frame.

But unfortunately, the splash screen is just one frame rendered for a
very long time, so the error lingered for a long time for everyone to
see.

Second, to determine what rotation to use, we should be looking at what
Vulkan told us, which is the value we pass to
VkSurfaceTransformFlagBitsKHR::preTransform.

This commit removes the now-unnecessary
screen_get_internal_current_rotation() function (which was introduced by
#96439) and now saves the preTransform value in the swapchain.
2024-10-31 16:52:26 -03:00
..
effects SCons: Add unobtrusive type hints in SCons files 2024-09-25 09:34:35 -05:00
environment Set clang-format `RemoveSemicolon` rule to `true` 2024-10-25 13:49:43 -04:00
forward_clustered Fix soft shadows by increasing the bit count for specialization constants. 2024-10-28 10:26:50 -03:00
forward_mobile Fix soft shadows by increasing the bit count for specialization constants. 2024-10-28 10:26:50 -03:00
shaders 2D: Fix various issues and minor performance optimisations 2024-10-30 08:36:45 +11:00
spirv-reflect SCons: Add unobtrusive type hints in SCons files 2024-09-25 09:34:35 -05:00
storage_rd Merge pull request #98652 from stuartcarnie/2d_texture_state_fixes 2024-10-29 19:25:54 -05:00
SCsub SCons: Add unobtrusive type hints in SCons files 2024-09-25 09:34:35 -05:00
cluster_builder_rd.cpp Fix missed light clusters when inside clipped lights 2024-03-13 23:38:46 +01:00
cluster_builder_rd.h Add Metal support for macOS (arm64) and iOS 2024-08-20 12:11:06 +02:00
framebuffer_cache_rd.cpp Implement hooks into renderer 2024-02-18 21:54:21 +11:00
framebuffer_cache_rd.h Implement hooks into renderer 2024-02-18 21:54:21 +11:00
pipeline_cache_rd.cpp Implement asynchronous transfer queues, thread guards on RenderingDevice. Add ubershaders and rework pipeline caches for Forward+ and Mobile. 2024-10-02 15:11:58 -03:00
pipeline_cache_rd.h Implement asynchronous transfer queues, thread guards on RenderingDevice. Add ubershaders and rework pipeline caches for Forward+ and Mobile. 2024-10-02 15:11:58 -03:00
pipeline_hash_map_rd.h Implement asynchronous transfer queues, thread guards on RenderingDevice. Add ubershaders and rework pipeline caches for Forward+ and Mobile. 2024-10-02 15:11:58 -03:00
renderer_canvas_render_rd.cpp 2D: Fix various issues and minor performance optimisations 2024-10-30 08:36:45 +11:00
renderer_canvas_render_rd.h 2D: Fix various issues and minor performance optimisations 2024-10-30 08:36:45 +11:00
renderer_compositor_rd.cpp Fix splash screen upside down on Android 2024-10-31 16:52:26 -03:00
renderer_compositor_rd.h Merge pull request #97934 from adamscott/give-AThousandShips-a-break 2024-10-29 19:25:36 -05:00
renderer_scene_render_rd.cpp Don't include `core/io/image.h` in `core/os/os.h` 2024-10-18 19:04:19 +03:00
renderer_scene_render_rd.h Set clang-format `RemoveSemicolon` rule to `true` 2024-10-25 13:49:43 -04:00
shader_rd.cpp Implement asynchronous transfer queues, thread guards on RenderingDevice. Add ubershaders and rework pipeline caches for Forward+ and Mobile. 2024-10-02 15:11:58 -03:00
shader_rd.h Implement asynchronous transfer queues, thread guards on RenderingDevice. Add ubershaders and rework pipeline caches for Forward+ and Mobile. 2024-10-02 15:11:58 -03:00
uniform_set_cache_rd.cpp Implement hooks into renderer 2024-02-18 21:54:21 +11:00
uniform_set_cache_rd.h Implement hooks into renderer 2024-02-18 21:54:21 +11:00