mirror of https://github.com/godotengine/godot
240f510fa7
This fixes UBSAN errors reported by running our testsuite, importing the TPS demo, and running the TPS demo. I have tried, wherever possible, to fix issues related to reported issues but not directly reported by UBSAN because thse code paths just happened to not have been exercised in these cases. These fixes apply only to errors reported, and caused by, core/ The following things have been changed: * Make sure there are no implicit sign changing casts in core. * Explicitly type enums that are part of a public API such that users of the API cannot pass in wrongly-sized values leading to potential stack corruption. * Ensure that memcpy is never called with invalid or null pointers as this is undefined behavior, and when the engine is built with optimizations turned on leads to memory corruption and hard to debug crashes. * Replace enum values only used as static values with constexpr static const values instead. This has no runtime overhead. This makes it so that the size of the enums is explicit. * Make sure that nan and inf is handled consistently in String. * Implement a _to_int template to ensure that all of the paths use the same algorhithm, and correct the negative integer case. * Changed the way the json serializer precision work, and added tests to verify the new behavior. The behavior doesn't quite match master in particulary for negative doubles as the original code tried to cast -inf to an int. This then led to negative doubles losing all but one of their decimal points when serializing. Behavior in GDScript remains unchanged. |
||
|---|---|---|
| .. | ||
| SCsub | ||
| callable_method_pointer.cpp | ||
| callable_method_pointer.h | ||
| class_db.cpp | ||
| class_db.h | ||
| make_virtuals.py | ||
| message_queue.cpp | ||
| message_queue.h | ||
| method_bind.cpp | ||
| method_bind.h | ||
| object.cpp | ||
| object.h | ||
| object_id.h | ||
| ref_counted.cpp | ||
| ref_counted.h | ||
| script_instance.cpp | ||
| script_instance.h | ||
| script_language.cpp | ||
| script_language.h | ||
| script_language_extension.cpp | ||
| script_language_extension.h | ||
| undo_redo.cpp | ||
| undo_redo.h | ||
| worker_thread_pool.cpp | ||
| worker_thread_pool.h | ||