1
0
Fork 0
Commit Graph

533 Commits

Author SHA1 Message Date
Lukas Tenbrink b5c31ebb41 Add contains_char() for single-character 'contains' calls. 2024-12-06 20:23:35 +01:00
kobewi 289e548e34 Untangle ColorPicker includes 2024-11-22 21:42:50 +01:00
A Thousand Ships 68f638cf02
Use `(r)find_char` instead of `(r)find` for single characters 2024-11-17 10:02:18 +01:00
kobewi 5be53c36c0 Simplify some UID conversions 2024-11-14 23:22:59 +01:00
kit f41cd8ad52 Make Goto line a Popup and allow column input 2024-10-31 10:11:46 -04:00
Haoyu Qiu a751c05b15 Fix script editor wrongly replaces and quotes non-ASCII letters 2024-09-23 00:05:16 +08:00
Rémi Verschelde d0a7dcd8c0
Merge pull request #96371 from KoBeWi/mentos
Improve dropping code in script editor
2024-09-03 16:14:02 +02:00
Rémi Verschelde 69888aabb8
Merge pull request #96179 from passivestar/mac-breakpoint-shortcuts
[macOS] Change breakpoint shortcuts to avoid conflicts
2024-09-03 11:43:31 +02:00
kobewi 731fd1f0b9 Improve dropping code in script editor 2024-08-31 11:35:59 +02:00
kobewi b4c92dbd0e Refactor toggling script list 2024-08-28 17:00:51 +02:00
Rémi Verschelde d35bee9cdd
Merge pull request #94002 from kitbdev/fix-goto-error
Fix goto line issues in code editor
2024-08-27 22:27:25 +02:00
passivestar 06baff5f01 [macOS] Change breakpoint shortcuts to avoid conflict with the settings shortcut 2024-08-27 23:12:32 +04:00
Haoyu Qiu 8bf4ecc026 Add `String.is_valid_unicode_identifier()`
- Adds `is_valid_unicode_identifier()`
- Adds `is_valid_ascii_identifier()`
- Deprecates `is_valid_identifier()`
- Renames `validate_identifier()` to `validate_ascii_identifier()`
2024-08-27 11:34:08 +08:00
kit 06b17a4d2f Fix goto line issues in code editor 2024-07-31 10:34:10 -04:00
Danil Alexeev 063a362755
Editor: Consider tabs when calculating column for jump to error 2024-07-17 18:20:50 +03:00
kit fc16465d17 Fix dropping on selection in script editor 2024-07-04 19:42:38 -04:00
A Thousand Ships 755a0efbb6
[Scene] Add `SceneStringNames::id_pressed` 2024-05-30 22:54:04 +02:00
Rémi Verschelde aa147b74ea
Merge pull request #90664 from KoBeWi/shadowdropped_resource
Prevent crash when dropping Resource that can't load
2024-05-30 11:47:38 +02:00
Rémi Verschelde 838eb5a0fd
Merge pull request #87099 from bitwise-aiden/ba-add-trim-newlines
Implement `trim_final_newlines` setting and functionality
2024-05-30 11:47:28 +02:00
Rémi Verschelde 408228889f
Merge pull request #92223 from KoBeWi/do_people_really_copy_whole_shortcut_definitions_multiple_times_and_unironically_think_this_is_alright_🤔
Remove duplicate shortcut definitions
2024-05-22 09:27:00 +02:00
Rémi Verschelde e34b97312e
Merge pull request #89630 from jsjtxietian/pick-color
Make "Pick Color"'s result less precise, keep only 3 decimals
2024-05-22 09:26:37 +02:00
kobewi e065d7132a Remove duplicate shortcut definitions 2024-05-21 23:28:49 +02:00
kobewi 413c11357d Use Core/Scene stringnames consistently 2024-05-13 23:41:07 +02:00
A Thousand Ships 955d5affa8
Reduce and prevent unnecessary random-access to `List`
Random-access access to `List` when iterating is `O(n^2)` (`O(n)` when
accessing a single element)

* Removed subscript operator, in favor of a more explicit `get`
* Added conversion from `Iterator` to `ConstIterator`
* Remade existing operations into other solutions when applicable
2024-05-04 16:08:55 +02:00
Aiden Storey b4c1634b52 Implement trim_final_newlines functionality 2024-05-02 22:57:34 -04:00
kit 773a473807 Overhaul multiple caret editing in TextEdit.
Use a multicaret edit to delay merging overlapping carets until the end.
2024-04-26 14:26:10 -04:00
kit 154f727c7a Overhaul TextEdit selection.
The caret is now a part of the selection.
2024-04-26 14:24:10 -04:00
kobewi 3a1246c198 Store line change in script navigation history 2024-04-25 23:22:47 +02:00
jsjtxietian be0dc52718 Make "Pick Color"'s result less precise, keep only 3 decimals 2024-04-15 19:48:41 +08:00
kobewi 64eff14a46 Prevent crash when dropping Resource that can't load 2024-04-14 15:26:53 +02:00
Alex Drozd fcb0b8d0bf Refactor check for overriden methods in inner classes 2024-03-26 22:14:57 +01:00
Alex Drozd 1d93a1fbb8 Fix missing gutter icon for inner class method overrides 2024-03-25 22:39:33 +01:00
Rémi Verschelde 05372773e1
Merge pull request #89599 from timothyqiu/vegetate
Fix unexpected auto translation of editor `Tree` content
2024-03-23 21:15:39 -07:00
Rémi Verschelde 1999b661d0
Merge pull request #89799 from timothyqiu/line-numbers
Translate "Line N" as a whole
2024-03-24 01:23:47 +01:00
Haoyu Qiu 9dadeac658 Translate "Line N" as a whole 2024-03-23 18:39:01 +08:00
VolTer de8b6f7a3c Add editor settings for autocompletion with NodePath and StringName 2024-03-19 17:23:54 +02:00
Haoyu Qiu 8cd1ebbd6d Fix unexpected auto translation of Tree content 2024-03-18 09:31:00 +08:00
Rémi Verschelde 4320d53a2b
Merge pull request #84907 from miv391/fix-gutter-error
Do not bother with line colors if `line_number_gutter` is not yet calculated
2024-03-04 20:43:30 +01:00
Mika Viskari 0fbc857e3f Do not call _validate_script if editor is not enabled 2024-03-01 19:48:48 +02:00
Muller-Castro 1638c1b28f Add const lvalue ref to editor/* container parameters 2024-02-26 15:28:15 -03:00
kobewi aeec3c1309 Add methods to add submenus without using names 2024-02-22 15:13:53 +01:00
Zi Ye 9281c441f6 Improved text editor status bar and zooming UX. 2024-02-21 17:33:16 -06:00
Rémi Verschelde 09df8f4a56
Merge pull request #87952 from paulloz/dotnet/byebye-signal-callback-generation
Disable signal callback generation in C#
2024-02-15 15:44:55 +01:00
Paul Joannon 9fa2355cef
Disable signal callback generation in C# 2024-02-14 13:26:45 +01:00
Rémi Verschelde 48e2f43ccf
Merge pull request #87479 from kitbdev/apply-ime
Fix TextEdit IME issues
2024-02-13 17:23:55 +01:00
Rémi Verschelde 76170379b3
Merge pull request #86633 from rune-scape/regression-79882
Fix possible crash (use after free) in ScriptTextEditor
2024-02-13 11:24:51 +01:00
kit a6af442b05 Apply TextEdit IME on most actions 2024-01-29 15:07:19 -05:00
Rémi Verschelde 745f8e112f
Revert "Add UID support to GDScript files"
This reverts commit c7f68a27ec.

We still think GDScript files need UIDs to allow safe refactoring,
but we're still debating what form those should take exactly.

So far there seems to be agreement that it shouldn't be done via an
annotation as implemented here, so we're reverting this one for now,
to revisit the feature in a future PR.
2024-01-29 21:00:26 +01:00
A Thousand Ships 15369fdb1d
Remove unnecessary `this->` expressions 2024-01-29 09:59:18 +01:00
Rémi Verschelde d3003c48b3
Merge pull request #67132 from KoBeWi/This_commit_message_is_auto-generated._Do_not_modify_it-
Add UID support to GDScript files
2024-01-18 16:33:14 +01:00
kobewi c7f68a27ec Add UID support to GDScript files 2024-01-17 22:30:56 +01:00
Yuri Sizov c027aecc2e Merge pull request #86676 from rune-scape/sparse-script-reload
GDScript: Hot-reload changed scripts only
2024-01-17 18:52:54 +01:00
Yuri Sizov 95b27fe8c7 Reorganize code related to editor theming
This change introduces a new EditorThemeManager class
to abstract theme generatio and its subroutines.

Logic related to EditorTheme, EditorColorMap, and editor
icons has been extracted into their respective files with
includes cleaned up.

All related files have been moved to a separate folder to
better scope them in the project. This includes relevant
generated files as well.
2024-01-16 11:57:45 +01:00
kobewi 0e8f90f4c8 Update deferred calls to use Callables 2024-01-09 16:11:47 +01:00
Rémi Verschelde 0010096356
Merge pull request #83109 from Calinou/script-editor-add-more-toggle-comment-shortcuts
Allow Ctrl + KP / and Ctrl + # to toggle comment in the script editor
2024-01-04 16:39:10 +01:00
Rémi Verschelde 6c390b620d
Merge pull request #84445 from Rubonnek/add-const-references-clang-tidy
Add const references detected by clang-tidy
2024-01-04 14:25:33 +01:00
Rémi Verschelde 11d1844e66
Merge pull request #85869 from paulloz/dotnet-warning-out-of-date-properties
.NET: Add a warning in the inspector when properties might be out of sync
2024-01-03 15:43:41 +01:00
rune-scape cde478bda6 Hot-reload only changed scripts 2024-01-02 17:56:52 -08:00
rune-scape a938359cd3 Fix possible crash in script_text_editor.cpp 2023-12-29 18:05:58 -08:00
Paul Joannon 0818d015db
Inspector ⚠️ when C# props might be out of date 2023-12-22 23:27:13 +01:00
Yuri Sizov ead01d0ca4 Merge pull request #85527 from fdstevex/master
Fix for Cmd-B shortcut conflict on macOS
2023-12-19 13:02:14 +01:00
Wilson E. Alvarez a3cb1b096f
Add const references detected by clang-tidy 2023-12-16 13:36:44 -05:00
Steve Tibbett 86db8f921d Fix for Cmd-B conflict on macOS, where Cmd-B was
both "Build Project" and "Go to Next Bookmark".
2023-11-30 06:58:52 -05:00
Yuri Sizov bc1949d797 Correctly check scripts that must inherit `EditorPlugin`
Also updates some error messages related to this kind of check
across the codebase.
2023-11-23 16:24:43 +01:00
Yuri Sizov b04b546092 Fix node names of submenu items across the editor
Also removes some programmer remarks and fixes some docs.
2023-11-08 14:42:42 +01:00
Rémi Verschelde 25fa5eadd5
Merge pull request #82986 from OmarShehata/fix-external-editor-hot-reload
Fix external editor hot reload for GDScript
2023-10-11 22:38:42 +02:00
Hugo Locurcio 936ad63709
Allow Ctrl + KP / and Ctrl + # to toggle comment in the script editor
This complements the existing Ctrl + K and Ctrl + / shortcuts.
2023-10-10 17:18:38 +02:00
Rémi Verschelde 71a8ac41fb
Merge pull request #72751 from dalexeev/doc-comment-color
Highlight doc comments in a different color
2023-10-09 23:21:54 +02:00
Danil Alexeev de7cbe8789
Highlight doc comments in a different color 2023-10-08 19:26:10 +03:00
A Thousand Ships f18aa00e85 Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable 2023-10-08 17:23:33 +02:00
Omar Shehata c25a2d832b Fix external editor hot reload 2023-10-07 22:14:54 -04:00
Joaquin Muñiz a93c19f373 create a constant when dropping a resource into the code editor while CRTL is held, and fix some inconsistencies 2023-09-27 14:37:00 -03:00
PucklaMotzer09 d2e651f403 Add Duplicate Lines shortcut to CodeTextEditor
This keyboard shortcut has been made with inspiration from the VS Code keyboard shortcut editor.action.copyLinesDownAction. It duplicates all selected lines and inserts them below no matter where the caret is within the line.
2023-09-25 23:41:31 +02:00
Rémi Verschelde f2baba6ddb
Merge pull request #81927 from KoBeWi/uid﹕﹕∕∕c1ick
Make UIDs clickable in the script editor
2023-09-20 13:10:08 +02:00
kobewi 3f43044a40 Make UIDs clickable in the script editor 2023-09-19 15:59:03 +02:00
ajreckof 6afadbaa9f Replace Ctrl in editor shortcuts with Cmd or Ctrl depending on platform 2023-09-19 10:29:07 +02:00
Yuri Sizov 8ecc0c4f47 Fix accessing editor theme items throughout the UI
This also exposes `EditorInterface::get_editor_theme`.
2023-09-15 14:51:01 +02:00
Jean-Michel Bernard 67dce301aa Add code region folding to CodeEdit 2023-09-11 18:36:40 +02:00
kobewi 6de34fde27 Add EditorStringNames singleton 2023-09-03 19:58:18 +02:00
jsjtxietian cfd7dfd985 Fix a crash when built-in script is not saved and have syntax error
When built-in script is not saved, it has empty path, and origin
code assumes error with empty path is a depended_error but that's
not always the case.
Also add protection before access list index 0.
2023-08-30 17:45:58 +08:00
kobewi 3f272f4910 Assume root when dropping node to unassigned script 2023-08-01 17:36:51 +02:00
Yuri Sizov 25f3f660c5 Merge pull request #79610 from aaronfranke/toggle-comment-slash
Add Ctrl+/ as a shortcut to toggle comment in addition to Ctrl+K
2023-07-31 21:01:17 +02:00
Yuri Sizov 74d20fe17e Merge pull request #75216 from rune-scape/rune-dependancy-errors
Script editor (GDScript): Show depended script errors
2023-07-24 19:32:20 +02:00
Yuri Sizov 2bd904e3db Merge pull request #73196 from Vilcrow/fix-lookup-symbol
Fix jumping to function definition using `Ctrl+LMB` or the "Lookup Symbol" button
2023-07-24 19:32:12 +02:00
rune-scape 83b01708b2 Script editor: Show depended script errors 2023-07-24 15:49:39 +02:00
Aaron Franke df3a1c18f1
Add Ctrl+/ as a shortcut to toggle comment in addition to Ctrl+K 2023-07-18 07:00:59 -05:00
S.V.I. Vilcrow 56e2fad319 Fixed the jumping to function definition using 'Ctrl+LMB' and the 'Lookup Symbol' button. 2023-07-12 21:30:35 +03:00
Theraot a51116c6c7 Make onready variables created from dropping nodes include custom types 2023-07-12 07:58:26 -05:00
Artyom Lunchenkov 613c060e0b
Add a line break to error messages in the script editor
Fixes #71002
2023-06-19 15:57:27 +02:00
ajreckof 006e899bb3 sort code completions with rules
Fixups

Add levenshtein distance for comparisons, remove kind sort order, try to improve as many different use cases as possible

Trying again to improve code completion

Sort code autocompletion options by similarity based on input

To make it really brief, uses a combination `String.similiary`, the category system introduced in a previous PR, and some filtering to yield more predictable results, instead of scattering every completion option at seemingly random.

It also gives much higher priority to strings that contain the base in full, closer to the beginning or are perfect matches.

Also moves CodeCompletionOptionCompare to code_edit.cpp

Co-Authored-By: Micky <66727710+Mickeon@users.noreply.github.com>
Co-Authored-By: Eric M <41730826+EricEzaM@users.noreply.github.com>
2023-05-23 05:12:34 +02:00
jmb462 d59cdb8327 Fix regression with right click on main selection 2023-05-08 21:56:16 +02:00
Rémi Verschelde eb6d6ab29f
Merge pull request #76658 from Paulb23/convert-indent-code-edit
Move convert_indent into CodeEdit
2023-05-08 12:20:37 +02:00
Jean-Michel Bernard 5c06c030f2 Fix right click in selection of additional caret 2023-05-08 00:02:56 +02:00
Paulb23 0b3fba45c6 Move convert_indent into CodeEdit 2023-05-07 13:08:37 +01:00
Rémi Verschelde 8f7b09916d
Merge pull request #76026 from YuriSizov/editor-running-up-that-gui
Extract editor run toolbar into its own component
2023-04-26 12:15:29 +02:00
kobewi ff310f0969 Add shortcut for quick-toggling word wrap 2023-04-19 23:46:22 +02:00
Yuri Sizov 8a74d8438f Extract editor run toolbar into its own component
- Simplify and update its logic.
- Simplify EditorScript.
- Improve EditorNode and other relevant includes.
- Fix scene-based path in the movie writer when
reloading a scene.
2023-04-19 17:12:28 +02:00
Danil Alexeev 06c7940a5a
Enable `RichTextLabel` context menu if selection is enabled 2023-03-06 13:18:36 +03:00
kobewi 5906d6de8e Fix line folding with multiple carets 2023-02-21 21:28:26 +01:00
bruvzg b3c64675cc
[macOS] Replace all `Alt/Option+Letter/Number` default shortcuts to avoid conflicts with special character input. 2023-02-20 22:02:47 +02:00