godotengine
/
godot
mirror of https://github.com/godotengine/godot
1
0
Fork 0
Code
77,710 Commits 19 Branches 65 Tags 3.7 GiB
Commit Graph

908 Commits

Author SHA1 Message Date
rune-scape a84c480049 Add missing CallableCustomMethodPointer for const methods 2024-09-23 11:46:10 -07:00
Rémi Verschelde 1b19ecb360
Merge pull request #95166 from aaronp64/variant_op_err_return 
Assign return value on `Variant` operator failure
 2024-09-23 12:27:51 +02:00
rune-scape cee0e6667a Refactor ref-counting code and fix ref counted releasing before aquiring 2024-09-21 11:36:58 -07:00
A Thousand Ships 203d3be200
[Core] Add way to check if a signal has any connections 
Added to `Object` and `Signal`
 2024-09-20 16:39:09 +02:00
Rémi Verschelde 6bf8a3e3f8
Merge pull request #95449 from SlashScreen/array_functions 
Add callable support for `find` and `rfind` `Array` methods
 2024-09-20 16:06:13 +02:00
aaronp64 714357e55c Assign return value on Variant operator failure 
Variant operators for String formatting and "in" could result in errors, which would return from validated_evaluate without assigning r_ret.  This would cause scripts using the return value from these operators to get results from previously run code.  Updated to return the original String value in the String formatting case, and false for "in" when an error occurs.
 2024-09-19 11:22:35 -04:00
Slashscreen 89491f4403 Add callable support for `find` and `rfind` `Array` methods 2024-09-13 00:01:53 -07:00
Thaddeus Crews b3d7960df4
Core: Fix `operator[]` for typed dictionaries 2024-09-12 11:10:17 -05:00
Rémi Verschelde 60ffa9645a
Merge pull request #96864 from KoBeWi/dictionerrory 
Fix `Dictionary.merge()` type validation
 2024-09-12 09:25:42 +02:00
Rémi Verschelde f8fbb860f5
Merge pull request #95840 from raulsntos/char_metadata 
Add metadata for `char16_t` and `char32_t`
 2024-09-12 09:25:19 +02:00
Raul Santos aaffab8afb
Add metadata for `char16_t` and `char32_t` 
We don't seem to expose any API that uses `char16_t` yet, but I added it anyway since we make the type info for it.

I didn't add anything for `wchar_t` because we are not making a type info so maybe we don't have a need for it yet, it could be added in the future.

To prevent breaking compatibility with the C# bindings, we ignore the `char32_t` metadata and still use `System.Int64`.
 2024-09-12 02:15:55 +02:00
Hilderin 27d1fb63e1 Fix Unable to use ResourceLoader in C# after threaded load in GDScript #92798 2024-09-11 19:03:55 -04:00
kobewi 48d5b8a8b8 Fix Dictionary.merge() type validation 2024-09-11 17:22:49 +02:00
Rémi Verschelde 0b4ae20156
Merge pull request #78656 from Repiteo/typed-dictionary 
Implement typed dictionaries
 2024-09-06 22:38:13 +02:00
Rémi Verschelde 4629f7d040
Merge pull request #96496 from aXu-AP/lerp-transform 
Add support for Transform2D/3D in `lerp()`
 2024-09-05 17:44:11 +02:00
Thaddeus Crews 9853a69144
Implement typed dictionaries 2024-09-04 10:27:26 -05:00
Rémi Verschelde 13a90e938f
Merge pull request #70096 from rune-scape/stringname-dict 
StringName Dictionary keys
 2024-09-03 17:38:06 +02:00
aXu-AP 7218dd6a3a Add support for Transform2D/3D in lerp() 
Implements godotengine/godot-proposals#10579
 2024-09-03 16:59:15 +03:00
Danil Alexeev 49bcdf78a7
Core: Сheck `r_error` after calling `callp()` 2024-08-30 21:09:30 +03:00
rune-scape 154049ce17 StringName Dictionary keys 
also added 'is_string()' method to Variant
and refactored many String type comparisons to use it instead
 2024-08-29 13:39:27 -07:00
Rémi Verschelde 622393c115
Merge pull request #95317 from esainane/when-i-am-64 
binder_common: Fix uninitialized marshalling for `PtrToArg<char32_t>`
 2024-08-28 17:15:05 +02:00
Rémi Verschelde 71accb9008
Merge pull request #94679 from rune-scape/remove-unused-initialize_ref 
Remove unused `initialize_ref`
 2024-08-28 00:12:16 +02:00
Haoyu Qiu 8bf4ecc026 Add `String.is_valid_unicode_identifier()` 
- Adds `is_valid_unicode_identifier()`
- Adds `is_valid_ascii_identifier()`
- Deprecates `is_valid_identifier()`
- Renames `validate_identifier()` to `validate_ascii_identifier()`
 2024-08-27 11:34:08 +08:00
Aaron Franke 7db24a9ad5
Simplify and fix Rect2/AABB get_support function 2024-08-19 23:55:31 -07:00
Sai Nane e6a7c63125 binder_common: Fix uninitialized marshalling 
C# uses `long`s to access many native values. With `PtrToArg<m_enum>` and
`PtrToArg<bitfield<m_enum>>` this isn't a problem, as C++ code converts
through a `*(int64_t*)` cast in assignment, so all 64-bits are initialized.

However, with `PtrToArg<char32_t>`, value assignment happens through an
`*(int *)` cast, leaving 32 bits uninitialized where `int` is 32 bits. On
platforms where `int` is 16 bits, there are presumably 48 bits uninitialized,
though there are very few platforms where this is still the case.

The easiest way to see the practical effects of this is by looking at
`EventInputKey.Unicode`:

```csharp
    public override void _Input(InputEvent @event) {
        if (@event is InputEventKey keyEvent) {
            if (keyEvent.IsPressed() && !keyEvent.Echo) {
                var raw = keyEvent.Unicode;
                var value = raw & 0xffffffff;
                GD.Print($"Key pressed: raw: {raw}; masked: {(char) value} ({value})");
            }
        }
    }
```

Pressing 'a' emits the following line:
```
Key pressed: raw: -3617008645356650399; masked: a (97)
```

Examining execution flow in gdb shows this conversion going through the
following line:
```
PtrToArg<char32_t>::encode (p_ptr=0x7ffcd5bb4b18, p_val=97 U'a') at ./core/variant/binder_common.h:221
221			*(int *)p_ptr = p_val;
```

Here, `p_val` is still 97, which is the value `InputEventKey.Unicode`
is expected to have. After assignment, `p *(int64_t *)0x7ffcd5bb4b18` displays
`-3617008645356650399`, with only the lower 32 bits being properly assigned,
and is the value we see from C#.

With this patch applied, the above testing `_Input` now prints:
```
Key pressed: raw: 97; masked: a (97)
```

Thank you to blujay1269 for asking about an unexpected value they saw in
`EventInputKey.Unicode`, which prompted this investigation.
 2024-08-09 05:15:54 +00:00
A Thousand Ships 8f3e2c96eb
[Core] Fix `Variant::construct` of `Object` 
Variant type was not updated correctly causing leaks in ref-counted
 2024-07-25 12:25:29 +02:00
Rémi Verschelde 496b7b8482
Core: Improve vformat error reporting on sprintf failure 
And fix a few occurrences of formatting errors that led me to this.
 2024-07-04 10:54:55 +02:00
rune-scape c8b697c64c Remove unused `initialize_ref` 2024-07-03 13:32:50 -07:00
Danil Alexeev 68481b6cdb
Core: Fix `Freed Object` booleanization 2024-07-03 09:49:47 +03:00
Rémi Verschelde 152d7c1bba
Revert "Make freed object different than null in comparison operators" 
This reverts commit 150b50cfcd.

As discussed with the GDScript team, this has some implications which aren't
fully consensual yet, and which we want to revisit.

For now we revert to the 4.2 behavior for the 4.3 release, to avoid breaking
user expectations.
 2024-07-01 14:11:43 +02:00
Rémi Verschelde 3d8562d775
Merge pull request #89197 from AThousandShips/arr_typed_fix 
[Core] Fix sharing of typed arrays from constructor
 2024-06-26 18:15:09 +02:00
bruvzg e651421905
[TextServer, GDExtension] Fix building text servers as GDExtension, expose new/changed low-level methods to GDExtension API. 2024-06-12 19:30:19 +03:00
bruvzg d8e1ab085a
[Windows] Fix 32-bit MinGW LTO build. 2024-06-04 13:46:03 +03:00
rune-scape 4463e7dee9 fix callable not clearing freed pointer 2024-06-02 21:22:16 -07:00
Thaddeus Crews 7599a7b719
Core: Readd Variant class initializer, fix comment 2024-05-14 12:20:40 -05:00
kobewi 413c11357d Use Core/Scene stringnames consistently 2024-05-13 23:41:07 +02:00
kobewi a262d2d881 Add shorthand for using singleton string names 2024-05-11 18:53:08 +02:00
A Thousand Ships b4c6cc7d82
[Core] Add case-insensitive `String::containsn` 2024-05-08 12:48:01 +02:00
Rémi Verschelde 63ed5749ac
Merge pull request #91104 from RandomShaper/simple_type_cpp 
Redefine `GetSimpleTypeT<>` in terms of `<type_traits>`
 2024-05-08 09:54:16 +02:00
Wilson E. Alvarez d4154dbc55
Add const char * overloads to String class 
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
 2024-05-07 10:53:00 -04:00
A Thousand Ships 09460d33e6
[Core] Fix sharing of typed arrays from constructor 2024-05-07 09:52:17 +02:00
K. S. Ernest (iFire) Lee f9b488508c
Add PackedVector4Array Variant type 
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
 2024-05-03 00:58:27 +02:00
kit cb17798df3 Add Array and Variant list inializer 2024-05-02 15:35:17 -04:00
A Thousand Ships 0f5e0d1637
Expose `Vector*` component-wise and scalar `min/max` to scripting 2024-05-02 13:02:40 +02:00
A Thousand Ships 308dbb8c63
[Core] Add scalar versions of `Vector*` `min/max/clamp/snap(ped)` 
Convenience for a number of cases operating on single values
 2024-05-02 10:31:13 +02:00
A Thousand Ships c4e24d2b3b
[GDScript] Correctly report invalid read-only access 2024-05-01 12:28:47 +02:00
Rémi Verschelde 4e30bc71f5
Merge pull request #91376 from clayjohn/DOCS-reflect-vec3 
Update the description and parameter name for Vector3 reflect to correct how the plane is constructed
 2024-05-01 09:55:27 +02:00
Rémi Verschelde 273a643145
Merge pull request #89647 from AThousandShips/read_only_dict 
[Core] Fix property access on read-only `Dictionary`
 2024-05-01 09:54:48 +02:00
clayjohn 4d580b15be Update the description and parameter name for Vector3 reflect to correct how the plane is constructed 2024-04-30 13:50:39 -07:00
Rémi Verschelde ef481148b2
Merge pull request #90394 from dsnopek/object-ptrcall-null-unlikely 
Use `likely()` in `PtrToArg<T *>` when checking for null `Object *`s
 2024-04-30 17:03:16 +02:00
kobewi f647888006 Make varray() variadic 2024-04-26 14:33:11 +02:00
Rémi Verschelde 2e92fb00d4
Merge pull request #90540 from Repiteo/core/type-info-use-type-traits 
Core: Use `<type_traits>` where applicable
 2024-04-24 18:55:07 +02:00
Pedro J. Estébanez dee65d1435 Redefine GetSimpleTypeT<> in terms of <type_traits> 2024-04-24 11:43:13 +02:00
Rémi Verschelde ff9d78c141
Merge pull request #90889 from timothyqiu/compat 
Use compatible text resource format when possible
 2024-04-23 19:11:46 +02:00
Rémi Verschelde cb1d6140be
Merge pull request #90866 from Repiteo/core/variant-initalizer-lists 
Core: Utilize initalizer lists in Variant constructors
 2024-04-23 19:11:29 +02:00
Haoyu Qiu 941e5c4820 Use compatible text resource format when possible 2024-04-23 12:04:44 +08:00
A Thousand Ships ec29c3e784
[Core] Fix property access on read-only `Dictionary` 2024-04-22 13:57:34 +02:00
Zhen Luo 6de2686913 Fix `RID` cannot be string formatted 2024-04-21 16:13:46 +08:00
Aaron Franke b1f5e9fe3a
Rename internal is_ascii_char to is_ascii_alphabet_char 2024-04-20 02:36:41 -07:00
Thaddeus Crews b95e7fcecd
Core: Integrate initalizer lists for Variant 2024-04-19 08:52:17 -05:00
A Thousand Ships 80cb914e06
[Core] Fix incorrect comparison for `Array` const iterator 2024-04-13 17:32:33 +02:00
Thaddeus Crews 127025679b
Core: Use `<type_traits>` where applicable 2024-04-11 13:13:59 -05:00
Rémi Verschelde 8764769ee8
Merge pull request #89186 from groud/save_byte_arrays_as_base64_encoded 
Save PackedByteArrays as base64 encoded
 2024-04-10 17:49:24 +02:00
A Thousand Ships 64146cb7f3
[Core] Add iteration support to `Array` 2024-04-10 14:49:34 +02:00
clayjohn c0d0bdc160
Clarify bounce and reflect docs and update param names 2024-04-10 14:07:08 +02:00
David Snopek 927f2e1e53 Use `likely()` in `PtrToArg<T *>` when checking for null `Object *`s 2024-04-08 11:06:56 -05:00
kobewi f0cbd388dc Ignore ERR_FILE_CANT_OPEN error when loading scene 2024-04-05 17:51:27 +02:00
Thaddeus Crews bbb3eb3a1a
Update lingering `do/while(0)` defines 2024-04-04 14:17:22 -05:00
Thaddeus Crews b0cda1f85f
Core: Use fixed-width integer types in Variant 2024-04-04 08:54:11 -05:00
Rémi Verschelde 9335b83a32
Merge pull request #87831 from Riteo/bitfield-xor 
Core: Implement a XOR operator for BitField
 2024-03-26 13:45:02 +01:00
A Thousand Ships 2cbf469912
Fix sorting of files/dirs in dialogs 
Sorts leading `_` before other characters except `.`.
 2024-03-20 13:45:47 +01:00
Rémi Verschelde 453485aede
Merge pull request #89270 from Repiteo/enforce-typename-in-templates 
Enforce template syntax `typename` over `class`
 2024-03-14 22:34:37 +01:00
Rémi Verschelde a1c476f9d7
Merge pull request #87680 from AThousandShips/the_angry_count 
Add methods to get argument count of methods
 2024-03-13 22:16:43 +01:00
A Thousand Ships 400f438e72
Fix `rpc` call from name based `Callable`s 2024-03-10 20:20:08 +01:00
A Thousand Ships 59bcc2888c
Add methods to get argument count of methods 
Added to:
* `Callable`s
* `Object`s
* `ClassDB`
* `Script(Instance)`s
 2024-03-10 11:02:43 +01:00
Thaddeus Crews 9903e6779b
Enforce template syntax `typename` over `class` 2024-03-07 22:39:09 -06:00
kobewi eb0a624902 Allow returning Dictionary after merging 2024-03-06 14:49:35 +01:00
Gilles Roudière de5073519e Save PackedByteArrays as base64 encoded 2024-03-06 10:17:31 +01:00
Rémi Verschelde 7434f8b4e3
Merge pull request #88959 from akien-mga/pre-commit-clang-17.0.6-black-24.2.0 
Pre-commit: Update to clang-format 17.0.6 and black 24.2.0
 2024-02-29 13:54:38 +01:00
Rémi Verschelde 9278856ff7
Merge pull request #88948 from dalexeev/core-add-callable-create 
Core: Add `Callable.create` static method for `Variant` callables
 2024-02-29 13:54:22 +01:00
Rémi Verschelde 1cc9190c70
Merge pull request #81822 from nlupugla/nodepath-slice 
Add `NodePath::slice` method
 2024-02-29 13:53:34 +01:00
Danil Alexeev d90c9db27f
Core: Add `Callable.create` static method for `Variant` callables 2024-02-29 10:45:00 +03:00
Rémi Verschelde 3a08c646ee
Pre-commit: Update to clang-format 17.0.6 and black 24.2.0 2024-02-28 14:25:35 +01:00
Robert Yevdokimov 13e82094ee Remove word duplicates in comments and strings, and fix casing and punctuation 2024-02-23 17:28:28 -05:00
Aaron Franke 1a6cabc0bf
Make Callable bind method const 2024-02-22 00:14:02 -06:00
Muller-Castro a8bc9f3e78 Add const lvalue ref to core/* container parameters 2024-02-14 11:20:36 -03:00
A Thousand Ships 684752e75b
Replace error checks against `size` with `is_empty` 2024-02-09 12:50:15 +01:00
Rémi Verschelde deda5f799b
Merge pull request #87992 from allenwp/87991-typed-array-additions 
Added newer Variant types to `typed_array.h`
 2024-02-07 11:04:01 +01:00
Rémi Verschelde dd2699be19
Merge pull request #67226 from Mickeon/typed-packing 
Use `Packed*Array` over `Vector<T>` in TypedArray
 2024-02-07 10:56:45 +01:00
Rémi Verschelde b41403db71
Merge pull request #67220 from Mickeon/variant-packing 
Use `Packed*Array` over `Vector<T>` in Variant
 2024-02-07 10:56:21 +01:00
Micky 2c98783359 Use `Packed*Array` over `Vector<T>` in TypedArray 
Same as #67220 but for `typed_array.h`
 2024-02-06 20:50:02 +01:00
Micky 3edb671b8a Use Packed*Array over Vector<T> in Variant 
Also shuffles some method definitions and declarations to be more consistent with the way the Variant types are ordered across the codebase.

And removes an unnecessary JSON assign (`JSON::stringify` can now be accessed statically)
 2024-02-06 12:53:19 +01:00
Allen Pestaluky f4134fd9b0 Added newer Variant types to typed_array.h 
Fixes #87991
 2024-02-05 16:37:11 -05:00
vittorioromeo 55ed34e37c Use '_v' shorthand for type traits and 'if constexpr' where appropriate 2024-02-02 15:43:21 +01:00
Riteo 7739940202 Core: Implement a XOR operator for BitField 2024-02-01 20:44:40 +01:00
Rémi Verschelde fa48a51183
Merge pull request #87688 from AThousandShips/what_is_this 
Remove unnecessary `this->` expressions
 2024-01-29 13:18:09 +01:00
A Thousand Ships 15369fdb1d
Remove unnecessary `this->` expressions 2024-01-29 09:59:18 +01:00
Mel Collins 8406e60522 Add InputEventKey.location to tell left from right 
This adds a new enum `KeyLocation` and associated property
`InputEventKey.location`, which indicates the left/right location of key
events which may come from one of two physical keys, eg. Shift, Ctrl.

It also adds simulation of missing Shift KEYUP events for Windows.
When multiple Shifts are held down at the same time, Windows natively
only sends a KEYUP for the last one to be released.
 2024-01-26 14:42:28 +01:00
Rémi Verschelde 0bcc0e92b3
Merge pull request #86730 from reduz/64-bit-cowdata 
Promote CowData to 64 bits
 2024-01-19 18:46:11 +01:00
Juan Linietsky 24fe0715b5 Promote CowData to 64 bits 
Fixes a lot of bugs, please help me fill the list.
 2024-01-19 17:41:10 +01:00
kobewi 0e8f90f4c8 Update deferred calls to use Callables 2024-01-09 16:11:47 +01:00
Muller-Castro 96a95cb974 Add const lvalue ref to container parameters 2024-01-05 14:49:57 -03:00
Rémi Verschelde 2bffa3cbc5
Merge pull request #82639 from golfinq/gdscript-improve-indexing-error 
GDScript: Improve error messages for invalid indexing
 2024-01-04 16:38:58 +01:00
Rémi Verschelde 18e9133d5a
Merge pull request #86364 from aaronfranke/basis-divide 
Add and expose Basis/Transform2D/3D division by float operator
 2024-01-04 14:26:16 +01:00
Rémi Verschelde 22e880ad20
Merge pull request #83163 from Chubercik/vectorXi_dist_methods 
Implement `Vector2i/3i/4i` methods: `distance_to` and `distance_squared_to`
 2024-01-03 09:58:36 +01:00
Rémi Verschelde b5c6e870e8
Merge pull request #82264 from dalexeev/core-builtin-methods-as-callables 
Core: Allow methods of built-in `Variant` types to be used as Callables
 2024-01-02 18:05:05 +01:00
Aaron Franke c77ae051d5
Add and expose Basis/Transform2D/3D division by float operator 2023-12-20 18:24:03 -06:00
Yuri Sizov 3a8524dd92
Merge pull request #83452 from RandomShaper/rd_common 
Split `RenderingDevice` into API-agnostic and `RenderingDeviceDriver` parts
 2023-12-20 20:09:18 +01:00
Aaron Franke 3f469ee485
Add PackedRealArray as an alias for Vector<real_t> 2023-12-18 11:37:43 -06:00
Aaron Franke d48d3ea4eb
Rename VariantZeroAssigner to VariantDefaultInitializer 
And the method zero() is now init()
 2023-12-17 14:00:30 -06:00
Yuri Sizov d02b368fd6 Merge pull request #78095 from aaronfranke/dict-get-or-set-default 
Add a `get_or_add` method to Dictionary
 2023-12-16 17:49:10 +01:00
Yuri Sizov ca19d34bde Merge pull request #73896 from vnen/object-null-boolean-consistency 
Make freed object different than null in comparison operators
 2023-12-16 17:49:05 +01:00
Pedro J. Estébanez fec76d0c22 BitField: allow chained set_flag(), make constructors constexpr 2023-12-15 13:14:59 +01:00
nlupugla cd221c1816 Added NodePath::slice method. 2023-12-13 13:30:28 -05:00
Aaron Franke 437586bf31
Add a `get_or_add` method to Dictionary 2023-12-06 11:43:58 -06:00
kobewi 1de0415118 Don't abort loading when ext_resource is missing 2023-11-22 12:13:32 +01:00
Rémi Verschelde 6ae6cc0bf5
Merge pull request #84815 from TokageItLab/array-animation 
Rework blending method in `Variant` animation for `Int`/`Array`/`String`
 2023-11-16 14:52:00 +01:00
Silc Lizard (Tokage) Renew 80c9533810 Rework blending method in Variant animation for Int/Array/String 2023-11-16 21:37:18 +09:00
Alistair Leslie-Hughes 5b6f641e99 Fix sizeof usage for Variant pointers in alloca 
Coverity report this as a non portable usage of sizeof
 2023-11-16 07:13:14 +11:00
kobewi 275e9d7028 Keep Variant type after zero() 2023-11-08 12:13:36 +01:00
Danil Alexeev b04263644c
Core: Allow methods of built-in `Variant` types to be used as Callables 2023-10-25 15:53:52 +03:00
Yuri Sizov 4952d37f4b Fix StringName leaks in VariantParser 2023-10-19 17:13:15 +02:00
Danil Alexeev 0c2202c56e
GDScript: Fix incorrect error message for utility functions 2023-10-16 14:09:57 +03:00
Jakub Marcowski cb954c6bab Implement `Vector2i/3i/4i` methods: `distance_to` and `distance_squared_to` 2023-10-12 13:46:49 +02:00
Rémi Verschelde a1d7c62df7
Merge pull request #83003 from AThousandShips/null_check_extra 
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
 2023-10-09 15:37:14 +02:00
Rémi Verschelde 35ede42d1d
Merge pull request #82695 from maiself/object-less-callables-fixes 
Fixes to allow object-less callables throughout Godot
 2023-10-09 15:32:38 +02:00
A Thousand Ships f18aa00e85 Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable 2023-10-08 17:23:33 +02:00
Mai Lavelle 5e15586ec2 Fixes to allow object-less callables throughout Godot 
This fixes #81887
 2023-10-06 16:31:35 -04:00
Rémi Verschelde a6a2d0d159
Merge pull request #82794 from dsnopek/gdextension-validated-call 
GDExtension: Convert `validated_call()` to `ptrcall()` (rather than `call()`)
 2023-10-06 16:50:57 +02:00
kobewi 09b30be86d Add vararg call() method to C++ Callable 2023-10-05 11:35:29 +02:00
David Snopek 55596eaac6 GDExtension: Convert `validated_call()` to `ptrcall()` (rather than `call()`) 2023-10-04 10:53:17 -05:00
Rémi Verschelde 5efbed51cc GDScript: Improve error messages for invalid indexing 
These errors are very common when using an invalid property name
or calling on an object of the wrong type, and the previous message
was a bit cryptic for users.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
Co-authored-by: golfinq <golfinqz@gmail.com>
 2023-10-02 14:23:11 -04:00
Jakub Janšta 74c937079c Add type_string() utility 2023-10-02 17:41:20 +02:00
Rémi Verschelde e95b7e84a4
Merge pull request #80844 from dalexeev/fix-callable-expected-argc 
Fix expected argument count for `Callable` call errors
 2023-10-02 13:15:53 +02:00
etti 3a39de4e2f Add rotate_toward and angle_difference to GDScript and C# 2023-10-01 22:19:42 +02:00
Danil Alexeev aff767ef07
Fix expected argument count for `Callable` call errors 2023-09-29 20:00:10 +03:00
Rémi Verschelde 737c308dcc
Merge pull request #74588 from puchik/float-variant-nan-inequality 
Support numeric/binary hash comparison for floats derived from Variants (as well as existing semantic comparison)
 2023-09-27 14:03:34 +02:00
Rémi Verschelde 3ec673085b
Merge pull request #79523 from aaronfranke/is-conformal 
Add `is_conformal` method to Basis and Transform2D
 2023-09-26 13:44:41 +02:00
Rémi Verschelde 7bb80b1525
Merge pull request #81741 from KoBeWi/vectoring_to_the_MAXXX 
Add `Vector2/3/4i.MAX` and `MIN`
 2023-09-17 14:47:52 +02:00
Rémi Verschelde 61df1deb61
Merge pull request #80075 from Bromeon/gdextension/optimize-ptrcalls 
GDExtension: `PtrToArg::convert()` uses const-reference where possible
 2023-09-17 14:46:13 +02:00
kobewi adc930baee Add Vector2/3/4i.MAX and MIN 2023-09-16 21:52:13 +02:00
Aaron Franke 56806ffeed
Add `is_conformal` method to Basis and Transform2D 2023-09-13 17:20:30 -05:00
A Thousand Ships 893f889d74 [Core] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable 2023-09-11 19:45:49 +02:00
Aaron Franke 6f7eccc758
Add a type conversion method to Variant Utility and expose to scripting 2023-09-08 10:12:48 -05:00
Yuri Sizov d8ff69d53c Extract ScriptInstance to simplify includes 
This allows to include script_instance.h directly in the
generated gdvirtual.gen.inc, and remove excessive includes
from the codebase.

This should also allow Resource to use GDVIRTUAL macros,
which wasn't possible previously due to a circular dependency.
 2023-09-06 22:54:38 +02:00
Daylily-Zeleen 67e1401891 Set builtin varrarg ptrcalls, called without arg. 2023-09-02 00:34:16 +08:00
Rémi Verschelde bbdd1aaa38
Merge pull request #81131 from AThousandShips/callable_fix 
Fix comparison of `Callable`s with binds
 2023-09-01 16:02:35 +02:00
Jcrespo 528a76486c Add inverse hyperbolic functions `asinh()`, `acosh()` & `atanh()` 
GDScript has the following built-in trigonometry functions:

- `sin()`
- `cos()`
- `tan()`
- `asin()`
- `acos()`
- `atan()`
- `atan()`
- `sinh()`
- `cosh()`
- `tanh()`

However, it lacks the hyperbolic arc (also known as inverse
hyperbolic) functions:

- `asinh()`
- `acosh()`
- `atanh()`

Implement them by just exposing the C++ Math library, but clamping
its values to the closest real defined value.
For the cosine, clamp input values lower than 1 to 1.
In the case of the tangent, where the limit value is infinite,
clamp it to -inf or +inf.

References #78377
Fixes godotengine/godot-proposals#7110
 2023-09-01 01:27:56 +02:00
Arman Elgudzhyan ee27254602 Support both semantic (by default) and numeric Variant hash comparison 
Hash comparison for Variant continues to perform semantic/logical comparison with NaN's considered equal by default (to prevent #16114, #7354, #6947, #8081), but now optionally allows for numeric comparison that does not consider NaN's equal to support proper value comparison (for #72222)
 2023-08-31 09:29:48 -07:00
A Thousand Ships 2caf5ae453 Fix comparison of `Callable`s with binds 2023-08-29 16:10:14 +02:00
Danil Alexeev 5d689ad560
Core: Fix recursion level check for `VariantWriter::write()` with objects 2023-08-29 15:05:53 +03:00
George Marques 150b50cfcd
Make freed object different than null in comparison operators 
This is so everything is consistent, as a freed object is not equivalent
to `null` in general. The booleanization of a freed object still returns
`false` to work as an easy check for validity of objects. Similarly, the
negation of a freed object returns `true`.

Also makes freed objects different from each other (if they are not the
same reference).
 2023-08-21 10:45:26 -03:00
Thaddeus Crews c82bdef2fc
Undefine typed array templates after use 2023-08-19 12:30:43 -05:00
Rémi Verschelde 1d70968e9a
Merge pull request #79370 from dalexeev/core-array-recursion-check 
Core: Fix recursion level check for array stringification
 2023-08-18 15:43:29 +02:00
Rémi Verschelde 20e24bd2bb
Merge pull request #78529 from Chaosus/string_reverse 
Add `String.reverse` method
 2023-08-16 16:53:40 +02:00
Jan Haller 38334fdc11 PtrToArg::convert() returns const-references where possible, avoids unnecessary copies 2023-08-07 20:40:23 +02:00
Rémi Verschelde 4ed08409b0
Merge pull request #78108 from aaronfranke/variant-util-header 
Make a header for VariantUtilityFunctions
 2023-08-03 14:46:29 +02:00
Joseph Davies 510de82f43
Fix typo in modulo error message. 2023-08-01 04:47:18 -07:00
Yuri Sizov 3d04a22d7c
Merge pull request #79103 from AThousandShips/array_slice_range 
Fix range error for `Array.slice`
 2023-07-17 16:48:48 +02:00
Danil Alexeev bb40bd9aaa
Core: Fix recursion level check for array stringification 2023-07-12 14:59:44 +03:00
Rémi Verschelde 0c1442f82a
Merge pull request #78551 from AThousandShips/call_rpc 
Fix `rpc` calls with binds
 2023-07-08 18:15:41 +02:00
Ninni Pipping 7752a0d8d1 Fix range error for `Array.slice` 2023-07-07 23:19:42 +02:00
Gabor Koncz a2ede8c4da Fix GDVIRTUAL_NATIVE_PTR 
This commit fixes the usage of GDExtensionPtr and GDExtensionConstPtr
in GDExtension by introducing the required VariantInternalAccessor
specializations.

Sponsored by Migeran (https://migeran.com)
 2023-07-03 10:52:02 +02:00
Ninni Pipping 9159208ed1 Ensure `RID`, `Callable`, and `Signal` are stored as strings 
Prevents parser errors in `.tscn` and `.tres` files where the assignment
would otherwise be empty.
 2023-06-22 17:01:08 +02:00
Ninni Pipping 7d174c8dfe Fix `rpc` calls with binds 2023-06-22 11:07:53 +02:00
Yuri Roubinski 230385b587 Add `String.reverse` method 2023-06-21 20:40:48 +03:00
Rémi Verschelde 248e5245e4
Merge pull request #73540 from mashumafi/fix-typed-array-add 
Fix: Typed arrays aren't working with +
 2023-06-20 15:12:39 +02:00
Rémi Verschelde 867ea7fe59
Merge pull request #74730 from MarioLiebisch/fix-74726 
Fix read-only dictionaries adding missing keys
 2023-06-19 21:38:38 +02:00
Rémi Verschelde b8bf28e2b6
Merge pull request #75758 from Pylgos/fix-gdextension-variant-construction 
Fix GDExtension Variant type conversion
 2023-06-19 10:27:20 +02:00
Rémi Verschelde 1a62f1e4fc
Merge pull request #74741 from vnen/variant-not-for-everyone 
Allow boolean operators for all Variant types
 2023-06-18 16:28:10 +02:00
Aaron Franke 7e9b5e59d4
Make a header for VariantUtilityFunctions 2023-06-12 11:29:42 -05:00
Aaron Franke 5654d40367
Don't use a const reference for the enum constructor in Variant 2023-06-11 15:13:05 -05:00
Pylgos d7eb7108f0 Fix gdextension variant type conversion 2023-06-10 10:52:17 +09:00
David Snopek 77733faede Attempt to standardize Object ptrcall encoding on `Object **` 2023-05-25 21:46:22 -05:00
Juan Linietsky 5fdc1232ef Add the ability to look-at in model-space. 
This is a much simpler attempt to solve the same problem as #76060, but without breaking any compatibility.

* Adds a description of what model space is in the Vector3 enums (MODEL_* constants). This has the proper axes laid out for imported 3D assets.
* Adds the option to `look_at` using model_space, which uses Vector3.MODEL_FRONT as forward vector.

The attempt of this PR is to still break the assumption that there is a single direction of forward (which is not the case in Godot)
and make it easier to understand where 3D models are facing, as well as orienting them via look_at.
 2023-05-24 10:10:24 +09:00
Emmanuel Leblond e785dd9dd9
Improve user-friendliness of "return value as function param" pattern in GDExtension API 
This commit introduce separate types (e.g. GDNativeStringPtr vs GDNativeUninitializedStringPtr)
depending on if the pointed data is already initialized (C++ style where constructor is alway
called when create a variable even if it is to be passed as return value) or not (C style).
On top of that, small changes has been made to `GDNativeInterface` so that it methods are
consistent on using uninitialized return value.
 2023-05-15 17:14:57 +02:00
clayjohn f83a90192f Revert "Add API for HSL conversion" 
This reverts commit 0b7fd664c1.
 2023-05-10 17:45:56 -03:00
Rémi Verschelde 0f444f101a
Merge pull request #76661 from bonjorno7/hsl 
Add API for HSL conversion
 2023-05-09 19:28:35 +02:00
Rémi Verschelde 5ade250c7d
Merge pull request #76735 from AThousandShips/natural_cmp 
Add `naturalcasecmp_to` function to `String`
 2023-05-09 17:44:37 +02:00
bonjorno7 0b7fd664c1 Add API for HSL conversion 
Math ported pretty much 1:1 from https://en.wikipedia.org/wiki/HSL_and_HSV
Style doesn't match the existing HSV code exactly, but should be close enough.
 2023-05-09 17:43:10 +02:00
Rémi Verschelde 491a437df5
Merge pull request #76540 from reduz/redo-remote-filesystem 
Redo how the remote filesystem works
 2023-05-08 13:52:51 +02:00
Rémi Verschelde 3e6a731904
Merge pull request #76418 from reduz/method-bind-validated-call 
Add ValidatedCall to MethodBind
 2023-05-08 13:52:42 +02:00
Juan Linietsky 273a6eeb66 Redo how the remote filesystem works 
Instead of reading files over the network, the new version uses a local file cache and only updates files when it changes.

The original remote filesystem was created 14 years ago, when ethernet was faster than hard drives or even flash. Also, mobile devices have a very small amount of storage.
Nowadays, this is no longer the case so the approach is changed to using a persistent cache in the target device.

Co-authored-by: m4gr3d
 2023-05-08 11:57:54 +02:00
Ninni Pipping 46a7018e3c Add `naturalcasecmp_to` function to `String` 
Functions as a complement to `naturalnocasecmp_to`
 2023-05-07 10:17:53 +02:00
Clay John 7a13cf9aeb
Merge pull request #75510 from SilicDev/string_erase 
Reimplement `String.erase()` as immutable method
 2023-05-05 10:03:49 -07:00
SilicDev 6fa4f71ca6 Reimplement String.erase 2023-05-04 00:52:35 +02:00
Juan Linietsky 1c93606e47 Add ValidatedCall to MethodBind 
* This should optimize GDScript function calling _enormously_.
* It also should simplify the GDScript VM considerably.

NOTE: GDExtension calling performance has most likely been affected until going via ptrcall is fixed.
 2023-04-30 20:01:26 +02:00
Aaron Franke 290b09b36c
Expose `determinant` in Transform2D, rename internal method 2023-04-22 13:44:14 -05:00
Paweł 899da22002 Fix lerp error message 2023-04-21 10:01:59 +02:00
kleonc 7a871212ed Fix expected argument count in Callable call error text 2023-04-19 16:06:00 +02:00
Haoyu Qiu 6cd8e706fa Unify descriptions of vector methods 
* is_equal_approx
* normalize
* length_squared
* posmod
* posmodv
 2023-04-14 23:31:33 +08:00
Pedro J. Estébanez 33f674d0f7 Complete support of callables of static methods 2023-04-12 18:12:19 +02:00
bendn ca0feabbb0
add `hex_decode()` to `String` 2023-04-05 19:44:00 +07:00
bruvzg d72b563250
Add GDScript `to_wchar_buffer` and `get_string_from_wchar` functions. 2023-03-21 15:39:54 +02:00
Yuri Sizov 6f4646c6bf
Merge pull request #74909 from AThousandShips/array_slice 
Fix `Array.slice()` rounding for `abs(step) != 1`
 2023-03-15 14:25:16 +01:00
Ninni Pipping 10f385fb79 Fix `Array.slice()` rounding for `abs(step) != 1` 2023-03-14 15:46:45 +01:00
Ninni Pipping c8c43997c7 Fix type check for max/min 2023-03-11 15:08:34 +01:00
Mario Liebisch 4e72e09343
Added the missing second case for string keys 2023-03-11 01:08:23 +01:00
George Marques a1e3ef919c
Add operator NOT for all Variant types 2023-03-10 15:58:55 -03:00
Mario Liebisch 46e5311d5a
Fixed read-only dictionaries adding missing keys 
When querying a non-existing key on a read-only
dictionary, the key was still added (albeit never set).

This fixes #74726.
 2023-03-10 17:26:34 +01:00
Ninni Pipping e6a9e0cdec Fix Variant hashing for floats 
Incorrectly hashed floats as single precision
 2023-03-08 12:52:50 +01:00
Rémi Verschelde 3863199ab9
Merge pull request #73881 from vnen/max-min-only-for-numbers 
Make max() and min() global functions only accept numbers
 2023-02-25 01:36:19 +01:00
Dmitrii Maganov c5f7a89b0f Core: Identity compare objects by id, not by pointers 2023-02-24 23:33:29 +02:00
George Marques ed81b165eb
Make max() and min() global functions only accept numbers 
The behavior for those are not well defined for non-numeric arguments.
To avoid confusion the other types are forbidden.
 2023-02-24 14:06:11 -03:00
mashumafi 2a12213c31 Fix: Typed arrays aren't working with + 2023-02-22 18:42:26 -05:00
Dmitrii Maganov 9cb2da89d6 GDScript: Fix usage of ints with typed array of floats 2023-02-13 22:06:38 +02:00
Rémi Verschelde 4a2c2170b4
Merge pull request #62921 from cdemirer/fix-variant-in 
Fix `Variant::in()` error on invalid `evaluate`
 2023-02-13 12:59:02 +01:00
cdemirer 44b2747dfd
Fix `Variant::in()` error on invalid `evaluate` 2023-02-13 12:37:41 +01:00
Gilles Roudière a825f955ab Make sure Variant is not implicitely cast when using operator[] 
Co-authored-by: Hein-Pieter van Braam-Stewart <hp@tmm.cx>
 2023-02-13 10:50:22 +01:00
Dmitrii Maganov 8400308ab3 GDScript: Fix can_reference check for typed arrays 2023-02-06 22:00:16 +02:00
Rémi Verschelde bbff9fd7a4
Merge pull request #71786 from raulsntos/dotnet/array 
Sync C# Array with Core
 2023-02-04 00:24:06 +01:00
George Marques 5fc7918594
GDScript: Improve usability of setter chains 
- Consider PackedArrays non-shared since they are copied on C++/script
  boundaries.
- Add error messages in the analyzer when assigning to read-only
  properties.
- Add specific error message at runtime when assignment fails because
  the property is read-only.
 2023-02-02 10:20:35 -03:00
Rémi Verschelde 394bb0ee2b
Fix various typos with codespell 
Finally do the childs -> children rename too.
 2023-02-01 08:45:41 +01:00
Dmitrii Maganov 5909f9f075 GDScript: Fix issues with typed arrays 2023-01-31 11:54:41 +02:00
bruvzg 5aa87ccc03
Move Array:set_typed to internal GDExtension structure and unexposed it. 2023-01-30 14:23:31 +02:00
Raul Santos 54f8fb010c
Sync C# Array with Core 
- Add `AddRange` method.
- Add `Fill` method.
- Add `Max` and `Min` methods.
- Add `PickRandom` method.
- Add `Reverse` method.
- Add `RecursiveEqual` method.
- Add `Sort` method.
- Add `Slice` and `GetSliceRange` methods.
- Add `IndexOf` overload that takes an index parameter.
- Add `LastIndexOf` method.
- Add `BinarySearch` method.
- Add/update documentation.
 2023-01-30 05:41:53 +01:00
Rémi Verschelde 9d555f5c68
Merge pull request #62499 from fire/gltf-binary-img-compression 
Handle gltf binary images
 2023-01-27 11:35:55 +01:00
K. S. Ernest (iFire) Lee 39922d7167 Handle gltf binary 
[ Ignore and Warn | Extract Textures (default) | Optimize Loading Embedded as Basisu ]

Enable compressed mip maps from Basis Universal for faster compressions.

Increase the quality of Basis to avoid corruption.

To keep compatibility use the first mip of the previous internal Godot format.

Because texture names may have invalid filename characters, adds String::validate_filename to sanitize filenames for import pipeline use.
 2023-01-27 02:02:02 -08:00
Dmitrii Maganov abe6d67232 GDScript: Fix test for read-only state of constants 2023-01-27 05:28:08 +02:00
Adam Scott 37248d7c87 Add `@GlobalScope` `is_same(a, b)` and `Variant::identity_compare()` 2023-01-25 10:46:21 -05:00
Jan Haller 15686ca786 Fix bind " convergence_dist" containing space 2023-01-23 20:07:59 +01:00
kobewi 615c517034 Use range iterators in LocalVector loops 2023-01-21 18:44:42 +01:00
Raul Santos 97610c8bfc
Add property usage to array indexer 
This makes the `Array` indexer show as returning `Variant` instead of `void` in the documentation.
 2023-01-19 14:22:11 +01:00
Rémi Verschelde 4005fc4b8d
Merge pull request #71279 from vonagam/fix-iterator-number-type 
GDScript: Fix typing of iterator in for loop
 2023-01-16 22:21:26 +01:00
Raul Santos 7560340ef6
Rename `center` method to `get_center` in Plane. 2023-01-15 17:18:50 +01:00
Dmitrii Maganov 40613ebd21 GDScript: Fix typing of iterator in for loop 2023-01-13 15:36:11 +02:00
Rémi Verschelde c2790ec2b9
Merge pull request #68450 from KoBeWi/bracket_escapist 
Allow to escape closing brackets in CFG tags
 2023-01-12 21:53:15 +01:00
Juan Linietsky 33d3b7eea7 Fix Callable call error reporting. 
* Fix potential crash when using bind in `Variant::get_callable_error_text()`
* Properly compute bound arguments so they can be properly shown.
* Add a function to obtain the actual bound arguments.
 2023-01-10 13:56:27 +01:00
Rémi Verschelde d3fc9d9e41
Merge pull request #71051 from vonagam/consts-are-deep-start 
GDScript: Begin making constants deep, not shallow or flat
 2023-01-09 23:22:59 +01:00
Rémi Verschelde 88940571f2
Merge pull request #71082 from AThousandShips/array_find_fix 
Fix for comparisons with PackedArrays
 2023-01-09 14:19:09 +01:00
Rémi Verschelde 31f94574d4
Merge pull request #70996 from reduz/properly-report-callable-bound-arguments 
Properly report Callable bound arguments
 2023-01-09 08:34:28 +01:00
Juan Linietsky 0e0ca01bce Properly report Callable bound arguments 
Fixes #63213
Adds a function: Callable::get_amount_of_arguments_bound() to query this in callables. Exposed to the engine API.
 2023-01-08 23:35:11 +01:00
Juan Linietsky 2b815df3c1 Use BitField<> in core type masks 
* All core types masks are now correctly marked as bitfields.
* The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks.
* Most bitmask operations replaced by functions in BitField<>
* Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is.
* Documentation and API dump updated to reflect bitfields in core types.
 2023-01-08 22:17:40 +01:00
Ninni Pipping 86240d97e1 Fix for PackedArray comparison 2023-01-08 21:22:28 +01:00
Dmitrii Maganov 5e2ac1a31e GDScript: Begin making constants deep, not shallow or flat 2023-01-08 07:29:10 +02:00
Rémi Verschelde 41b74c675f
Merge pull request #71000 from reduz/callable-bind-from-array 
Allow binding Callable arguments from an array
 2023-01-07 13:18:53 +01:00
Juan Linietsky d762a0395a Allow binding Callable arguments from an array 
Restores 3.x functionality that was removed in the Signal/Callable refactor of 4.0.

Fixes #64668.
Implements https://github.com/godotengine/godot-proposals/issues/6034

Usage:

```GDScript

callable.bindv([arg1,arg2,arg3])

```
 2023-01-06 22:37:25 +01:00
Juan Linietsky 576ae694e0 Unbind Variant methods that change immutable types. 
Fixes #62706.
Code is commented instead of removed to clarify why they should not be re-added.
 2023-01-06 17:17:43 +01:00
Rémi Verschelde d95794ec8a
One Copyright Update to rule them all 
As many open source projects have started doing it, we're removing the
current year from the copyright notice, so that we don't need to bump
it every year.

It seems like only the first year of publication is technically
relevant for copyright notices, and even that seems to be something
that many companies stopped listing altogether (in a version controlled
codebase, the commits are a much better source of date of publication
than a hardcoded copyright statement).

We also now list Godot Engine contributors first as we're collectively
the current maintainers of the project, and we clarify that the
"exclusive" copyright of the co-founders covers the timespan before
opensourcing (their further contributions are included as part of Godot
Engine contributors).

Also fixed "cf." Frenchism - it's meant as "refer to / see".
 2023-01-05 13:25:55 +01:00
George Marques 0c15844551
GDScript: Error when assigning return value of void function 
This also makes built-in method calls empty the return value when the
method is void, to avoid keeping returning a garbage value in such case.
 2022-12-30 12:08:58 -03:00
Yuri Rubinsky fff3d812a5 Fix empty zero assigners for the variant types 2022-12-20 19:02:44 +03:00
Rémi Verschelde 762c6d4b36
Merge pull request #69709 from RandomShaper/refactor_spirv_reflection 
Refactor SPIR-V reflection into a generic RenderingDevice feature
 2022-12-15 09:21:35 +01:00
lawnjelly 491594ef0f VariantParser make readahead optional 
It turns out some areas are independently moving / reading filepointers outside of the VariantParser, which can cause the readahead caching to get out of sync.

This PR makes the VariantParser readahead to be optional to allow for these use cases.
 2022-12-12 15:14:39 +00:00
Pedro J. Estébanez 2095ca26d0 Add default, zeroing constructor to BitField 2022-12-12 12:12:26 +01:00
Rémi Verschelde f1edd03d4c
Merge pull request #69718 from groud/finally_rename_gdnative_to_gdextension 
Rename all gdnative occurences to gdextension
 2022-12-12 11:43:59 +01:00
Gilles Roudière be1c9d677d Rename all gdnative occurences to gdextension 
Non-exhaustive list of case-sensitive renames:

GDExtension -> GDNative
GDNATIVE -> GDEXTENSION
gdextension -> gdnative
ExtensionExtension ->Extension (for where there was GDNativeExtension)
EXTENSION_EXTENSION ->EXTENSION (for where there was GDNATIVE_EXTENSION)
gdnlib -> gdextension
gdn_interface -> gde_interface
gdni -> gde_interface
 2022-12-12 11:04:57 +01:00
Rémi Verschelde 907298d673
Merge pull request #68747 from rune-scape/rune-stringname-unification 
GDScript: Unify StringName and String
 2022-12-09 18:06:48 +01:00
Aaron Franke d543ddf1c9
Fix Variant StringName `is_zero` being inverted 2022-12-06 21:49:43 -06:00
rune-scape e79be6ce07 Unify String and StringName 2022-12-05 21:46:47 -05:00
Rindbee 694ee1bf52 Fix suppressed error message on error when using % format string 
Before, the valid flag would always be true. On formatting errors,
an error message is returned as the result. (No error prompts.)
 2022-12-05 22:09:10 +08:00