Check identifiers (const variables and unnamed enums) and named
enums when parsing dictionary literals whether the keys are not
duplicated.
In case of duplicate key is encountered, highlight the line with it
and print error message:
`Duplicate key "foo" found in Dictionary literal`
This commit is a logical continuation of the commit dab73c7 which
implemented such checks only for literal keys (which fixed#7034).
Apart from that, this commit also fixes the issue with the error
message itself, which was shown one line below the duplicated key
in case it was the last one in the dictionary literal and there
was no hanging comma.
Also, the format of the error message has been changed so that now
the error message also contains the value of the key which is duplicated.
Instead of `Duplicate key found in Dictionary literal`, it now prints
`Duplicate key "<value>" found in Dictionary literal`
Fixes#50971
libvpx arm32 build with NEON can be supported in theory (and it works
on Android armv7), but our SCons logic for it is super convoluted and
broken. It needs significant rework to be made less error prone, and
ensure we can compile `.s` files properly with cross-compilation
toolchains.
The demand to play WebM videos on older Pi3-style SoCs is likely low,
so for now this is a simple compromise.
Could be improved with some effort if someone is motivated.
Still paying the cost of not having refactored all architecture handling
in the 3.x branch so we have this broken hybrid of arch/bits which is
unreliable.
The architecture handling in 3.x is all over the place, and I'm not
going to start a major refactor like I did for 4.0 so late in its life
cycle.
So let's add more hacks! ⚔️
This requires manually passing `arch=arm64` when compiling, but this is
already the case for other parts of the codebase.
The commit b5a8055b5c should target GCC builds only as
-flax-vector-conversions has different behaviour in Clang and is
currently making the build fail.
Signed-off-by: Filipe Rinaldi <filipe.rinaldi@gmail.com>
(cherry picked from commit 2841144096)
This is a change done upstream in the `devel3` branch for 3.13.6:
82ca6b5ccb
They also seem to define it for macOS, but for us it breaks the build...
¯\_(ツ)_/¯
Also change wrong use of CPPFLAGS (pre-processor) where CXXFLAGS (C++)
makes more sense.
(cherry picked from commit b5a8055b5c)
Upon investigating the extremely slow MSVC build times in #80513, I noticed
that while Godot policy is to never use exceptions, we weren't enforcing it
with compiler flags, and thus still included exception handling code and
stack unwinding.
This is wasteful on multiple aspects:
- Binary size: Around 20% binary size reduction with exceptions disabled
for both MSVC and GCC binaries.
- Compile time:
* More than 50% build time reduction with MSVC.
* 10% to 25% build time reduction with GCC + LTO.
- Performance: Possibly, needs to be benchmarked.
Since users may want to re-enable exceptions in their own thirdparty code
or the libraries they compile with Godot, this behavior can be toggled with
the `disable_exceptions` SCons option, which defaults to true.
Rémi Verschelde
Mikael Hermansson
Haoyu Qiu
lawnjelly
Kirill Diduk
Ansraer
Fabio Alessandrelli
Danil Alexeev
lawnjelly
Caroline Joy Bell
A Thousand Ships
Andy Savage
Filipe Rinaldi
David Snopek
Rarysson Guilherme
Jason Knight
ryanabx
BlueCube3310
SysError99
DeeJayLSP
Hugo Locurcio