1
0
Fork 0
Commit Graph

536 Commits

Author SHA1 Message Date
Thaddeus Crews e4dbba94d9
Merge pull request #99324 from TokageItLab/fix-fpe-spinner
Fix spinner in AnimationTrackEdit in FPS mode
2024-11-19 15:20:10 -06:00
Thaddeus Crews 63a408f320
Merge pull request #99363 from passivestar/fix-marker-drawing
Fix issues with animation markers drawing
2024-11-19 15:20:04 -06:00
passivestar c4a78d09e5 Fix issues with animation markers drawing 2024-11-19 19:45:36 +04:00
A Thousand Ships 68f638cf02
Use `(r)find_char` instead of `(r)find` for single characters 2024-11-17 10:02:18 +01:00
Silc Lizard (Tokage) Renew e283fdfb59 Fix spinner in AnimationTrackEdit in FPS mode 2024-11-17 01:54:06 +09:00
Silc Lizard (Tokage) Renew 602c5edbc4 Fix key is deselected by chaning key time in KeyEdit in FPS mode 2024-11-16 23:48:10 +09:00
Thaddeus Crews 75dc6e19cd
Merge pull request #98826 from UnfavorableEnhancer/animation-editor-snap-fix
Fix animation editor snapping value not lowering as intended when holding shift
2024-11-12 12:13:03 -06:00
Thaddeus Crews 93815e7e97
Merge pull request #99013 from TokageItLab/fps-compat-toggle
Add FPS compatible option in second mode of the animation editor snapping
2024-11-11 14:18:24 -06:00
Silc Lizard (Tokage) Renew 64d04c375c Add FPS compatible option in second mode of animation editor snapping 2024-11-12 04:39:13 +09:00
UnfavorableEnhancer d9a1e65d50 fix holding shift not lowering animation snap 2024-11-11 13:12:09 +03:00
Jason Morgado d5176757c0 Add type filters to AnimationPlayer's "Add Track"
Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-Authored-By: Tomek <kobewi4e@gmail.com>
2024-11-09 10:14:06 -05:00
Thaddeus Crews bb5f390fb9
Style: Apply `clang-tidy` fixes (superficial)
• `modernize-use-bool-literals`, `modernize-use-nullptr`, and `readability-braces-around-statements`
2024-11-04 12:11:14 -06:00
Aaron Franke 562c666e3d
Rename internal Button icon to button_icon to match exposed methods 2024-10-29 16:23:03 -07:00
kobewi d5fbc7dab1 Improve Scale Selection in Animation tab 2024-10-22 15:54:17 +02:00
Haoyu Qiu 3d07fced0c Fix typos in `AnimationMarkerEdit` 2024-10-17 08:12:00 +08:00
Thaddeus Crews e15000eb45
Merge pull request #97833 from AtlaStar/Fix-issue-97832
Allow seconds snapping to use minimum intervals of 0.0001 once more
2024-10-14 14:09:55 -05:00
Thaddeus Crews 168e605ad7
Merge pull request #97563 from SaracenOne/key_sub_paths
Fix keying of property subpaths.
2024-10-10 18:13:21 -05:00
Derrick Melton 8c93e8667c Allow seconds snapping to use minimum intervals of 0.0001 once more
closes #97832, also clears up some of the naming conventions used. Confirmed that entering values when `seconds` is selected where the fractional part is less than 0.0001 floors, while fractional values greater than that are retained. Doesn't revert previous behaviors for FPS, which still clamp to the nearest 1/16.
2024-10-10 15:42:37 -07:00
Derrick Melton 8a8d40ccc0 Allow fractional FPS values in Animation Editor
Closes #97548. Care also taken to not reopen issue #92273 by ensuring that the value rounds to the nearest sixteenth. Optionally any factor of 2 should work while ensuring that there isn't error accumulation.

Further testing to ensure issue #91729 isn't reopened, but initial testing suggests that the issue will not reopen with this PR.
2024-10-02 16:46:11 -07:00
chocola-mint ed13a840fa Add markers to animation 2024-09-29 17:27:36 +09:00
Saracen 77e803f2f3 Fix keying of property subpaths. 2024-09-28 06:52:05 +01:00
Haoyu Qiu 14321b8ed5 Set auto translate mode for drag previews
- Controls
  - `LineEdit`, `TextEdit`: Always disabled since it's dragging user input.
  - `TabBar`: Use the same auto translate mode as the node.
  - `RichTextLabel`: Always disable since auto translation is done
    differently from other controls (selection text you get
    programmatically is always after auto translation).
- Editor
  - Disable drag preview auto translation if the text is user input,
    filename, or class name.
  - Also disabled unexpected auto translation for audio bus effect names.
2024-09-19 19:21:29 +08:00
Mounir Tohami 3af4eb9207 Fix animation `bezierEditor` uses only half the view. 2024-09-17 11:59:12 +00:00
Rémi Verschelde 86b40fe637
Merge pull request #96902 from SaracenOne/animation_selection_box
Fix selection box + scrolling in animation editor.
2024-09-16 13:35:18 +02:00
Rémi Verschelde 4d35402c1c
Merge pull request #96400 from Maran23/inputmap-usage-for-filter-and-corresponding-refactor
Use InputMap actions consistently across all LineEdit's that filter an underlying Tree or ItemList.
2024-09-16 13:34:38 +02:00
Saracen 86fc8ef99b Fix selection box + scrolling in animation editor. 2024-09-15 15:09:13 +01:00
Dowsley 9d0944b673
Update AnimationPlayer in real-time when bezier curve properties or bezier editor changes 2024-09-12 09:34:05 +02:00
Saracen 09515bfc6c Fix errors when creating bezier component tracks. 2024-09-10 08:33:42 +01:00
Kasper Arnklit Frandsen 88a866fb5a Add separate timeline snapping control to Animation Editor 2024-09-02 15:57:50 +02:00
Rémi Verschelde 71091f14ac
Merge pull request #96428 from SaracenOne/timeline_display_fix
Fix overlapping in animation timeline display.
2024-09-02 12:13:53 +02:00
Rémi Verschelde 7795849908
Merge pull request #96013 from passivestar/keyframe-navigation
Allow jumping to previous/next keyframe in animation player
2024-09-02 12:13:00 +02:00
Saracen 32e1143bfc Fix overlapping in animation timeline display. 2024-09-01 09:41:19 +01:00
passivestar a7abbe5e9e Allow jumping to previous/next keyframe in animation player 2024-09-01 04:57:58 +04:00
Saracen 1deb42ad8d Improve behaviour of AnimationPlayer warnings. 2024-09-01 01:32:56 +01:00
Marius Hanl 74f64aaf98 Use InputMap actions consistently across all LineEdit's that filter an underlying Tree or ItemList.
- Instead of checking for Key::UP, Key::DOWN, Key::PAGEUP, Key::PAGEDOWN etc., we rather check for the action like 'ui_up' or 'ui_down'.
- Also use AcceptDialog's 'register_text_enter' functionality to consistently close a dialog when ENTER is pressed while the LineEdit has focus (instead of redirecting ENTER keys to e.g. the underlying Tree).
- Unify the LineEdit filter behavior for the SceneTreeDialog and corresponding usages
- Improve OK Button disablement (something should be selected)
2024-08-31 21:10:27 +02:00
Rémi Verschelde 52d1b0be4a
Merge pull request #96328 from object71/fix-animation-snap-96159
Add `modf` function and fix animation editor snap behavior
2024-08-30 23:38:02 +02:00
Rémi Verschelde 7753900638
Merge pull request #91599 from dnllowe/realtime-animation-player-property-updates
Update AnimationPlayer in real-time when keyframe properties change
2024-08-30 23:37:42 +02:00
Hristo Iliev fcc8518bce Add modf function and fix snap behavior
Fixes #96159
2024-08-30 17:49:57 +03:00
Rémi Verschelde 1e57671718
Merge pull request #90130 from KoBeWi/erased_from_history
Expose EditorUndoRedoManager's `clear_history()`
2024-08-30 11:42:58 +02:00
Rémi Verschelde b310e5e064
Merge pull request #92842 from mihe/multi-node-keying
Allow keying properties when selecting multiple nodes
2024-08-30 09:59:01 +02:00
kobewi ad7a2d19a6 Expose EditorUndoRedoManager's clear_history() 2024-08-29 19:23:39 +02:00
Rémi Verschelde a5e157dd37
Merge pull request #91854 from ImpishOaths/PullReady
Don't lose in/out handles when bezier keyframe inserted on top of existing keyframe
2024-08-26 22:44:52 +02:00
Daniel Lowe 67a5932a4f Update AnimationPlayer in real-time when keyframe properties change 2024-08-26 07:19:01 -04:00
passivestar 155033384c Fix animation timeline resize widget allowing impossible internal values 2024-08-22 16:32:38 +04:00
passivestar 6120786ddc Allow theming animation editor 2024-08-21 15:29:27 +04:00
Mikael Hermansson 351f454a94 Allow keying properties with multiple nodes selected 2024-08-19 14:05:33 +02:00
A Thousand Ships 4fe0d0ee86
[Editor] Fix `AnimationTrackEditor::timeline_changed` signal
Signal was declared with two arguments, emitted with both two and three
2024-08-13 15:09:53 +02:00
Silc Lizard (Tokage) Renew b075eba68c Fix BlendShapeTrack insertion totally not working 2024-07-25 23:52:31 +09:00
BrinerLovo bf01119cdf
Animation: Fix reset value when adding new Bezier track
Fixes #81929.

In Float and Integer types, there is no subindex – only the primary value.
Currently, trying to retrieve a subindex from these types in the Variant leads
to a return value of null. To address this, the proposed change ensures that
the default value is returned for these types instead of attempting an invalid
subindex retrieval.
2024-07-08 23:18:03 +02:00
ImpishOaths 0f7c4d8375 Don't lose in/out handles when bezier keyframe inserted on top of existing keyframe
Apply suggestions from code review

Co-authored-by: Silc Lizard (Tokage) Renew <tokage.it.lab@gmail.com>
2024-07-08 09:05:07 -07:00
Silc Lizard (Tokage) Renew fae712d968 Fix broken sync between animation TrackEditor and PlayerEditor 2024-07-06 04:45:15 +09:00
Rémi Verschelde d2fc2a35b3
Merge pull request #92985 from KoBeWi/confirm_insert_shift
Restore "Confirm Insert Track" editor setting
2024-07-05 15:07:29 +02:00
Kasper Frandsen 7c6f32ddbf Clamp bezier handle length to half the length of animation 2024-07-04 13:41:12 +01:00
Silc Lizard (Tokage) Renew dde616f01c Revert the default InterpolationType with angle property to Linear 2024-06-28 21:22:11 +09:00
Rémi Verschelde eeef96b144
Merge pull request #93408 from CookieBadger/animation-track-key-inspector-fix
Fix displaying selected Bezier animation keys in inspector
2024-06-28 11:34:52 +02:00
emild 2b8b21c7f8 fix animation bezier keys not showing in inspector after selection 2024-06-21 12:29:33 +02:00
A Thousand Ships fbb879debd
[Scene] Add `SceneStringNames::text/value_changed` 2024-06-19 09:44:38 +02:00
A Thousand Ships ca18a06ecb
[Scene] Add `SceneStringNames::confirmed` 2024-06-19 09:40:54 +02:00
A Thousand Ships d9e2fc74c7
[Scene] Add `SceneStringNames::item_selected` 2024-06-19 09:39:05 +02:00
A Thousand Ships d519715d94
[Scene] Add `SceneStringNames::font(_size/_color)` 2024-06-18 17:24:27 +02:00
Rémi Verschelde a06a5e2ff1
Merge pull request #93257 from bruvzg/antrk_popup_drag
[AnimationTrackEdit] Cancel key drag when popup is shown.
2024-06-18 14:08:52 +02:00
Rémi Verschelde d66281c7b8
Merge pull request #80860 from RandomShaper/harmonize_track_insert
Simplify right-click track insertion code
2024-06-17 10:57:42 +02:00
bruvzg 0e76739bd6 [AnimationTrackEdit] Cancel key drag when popup is shown. 2024-06-17 10:22:58 +03:00
Rémi Verschelde e988c1a682
Merge pull request #92870 from KoBeWi/maybe_RESET_a_bit_less
Don't allow creating invalid RESET keys
2024-06-13 17:19:23 +02:00
Pedro J. Estébanez 9ba984e2c1 Simplify right-click track insertion code 2024-06-13 09:37:47 +02:00
kobewi 21345defe9 Restore "Confirm Insert Track" editor setting 2024-06-10 17:47:59 +02:00
kobewi 461bb8ee02 Don't allow creating invalid RESET keys 2024-06-07 15:02:13 +02:00
Silc Lizard (Tokage) Renew b83dc9b25b Fix unstable AnimationTrackEditor snapping value 2024-06-04 22:06:40 +09:00
A Thousand Ships 926afccbd8
[Scene] Add `SceneStringNames::panel` 2024-05-30 22:54:50 +02:00
A Thousand Ships 755a0efbb6
[Scene] Add `SceneStringNames::id_pressed` 2024-05-30 22:54:04 +02:00
kobewi e065d7132a Remove duplicate shortcut definitions 2024-05-21 23:28:49 +02:00
A Thousand Ships ee79386f7b
[Scene] Add SceneStringNames::pressed 2024-05-14 15:51:28 +02:00
kobewi 413c11357d Use Core/Scene stringnames consistently 2024-05-13 23:41:07 +02:00
kobewi a262d2d881 Add shorthand for using singleton string names 2024-05-11 18:53:08 +02:00
A Thousand Ships b4c6cc7d82
[Core] Add case-insensitive `String::containsn` 2024-05-08 12:48:01 +02:00
Rémi Verschelde 4b070e8031
Fix various typos with codespell
Using 2.2.7.dev217+g10c2abcf.

Had to add `colour` to the ignore list as we used it as an alias/keyword for the
documentation of color-related APIs.
Also ignore recommendations to change `thirdparty` to either `third-party` or
`third party`, which are correct but we use the former fairly consistently.
2024-05-07 10:08:42 +02:00
A Thousand Ships 955d5affa8
Reduce and prevent unnecessary random-access to `List`
Random-access access to `List` when iterating is `O(n^2)` (`O(n)` when
accessing a single element)

* Removed subscript operator, in favor of a more explicit `get`
* Added conversion from `Iterator` to `ConstIterator`
* Remade existing operations into other solutions when applicable
2024-05-04 16:08:55 +02:00
K. S. Ernest (iFire) Lee f9b488508c
Add PackedVector4Array Variant type
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2024-05-03 00:58:27 +02:00
Silc Lizard (Tokage) Renew fc21161525 Make adding track process to set interpolation type on creating RESET 2024-04-27 11:39:30 +09:00
RedMser 9cd30208d6 Improve SceneTreeEditor usability
- Mark contextually relevant node
- Remember/Clear selection as appropriate
- Scroll to marked/selected node
2024-03-31 21:35:10 +02:00
Rémi Verschelde 05372773e1
Merge pull request #89599 from timothyqiu/vegetate
Fix unexpected auto translation of editor `Tree` content
2024-03-23 21:15:39 -07:00
Rémi Verschelde 0ca0e8fc49
Merge pull request #88498 from CookieBadger/animation-fix-snapping-multiple
Fix snapping multiple keys in Animation
2024-03-24 01:14:23 +01:00
Rémi Verschelde b0505b580d
Merge pull request #88445 from CookieBadger/animation-paste-snap-fix
Fix various bugs in Animation key right click actions
2024-03-24 01:14:08 +01:00
Hilderin b46d0a6ea8 Add auto focus timeline and bezier scale on animation editor
Add a button at the bottom of the animation editor that change the zoom based on the animation length and the bezier scale based on the values and handles of the displayed tracks. The icon and the tooltip of the button change depending if the bezier editor is displayed or not.

Some refactor was made in animation_track_editor.cpp to remove code duplication with the visibility check of the tracks.

This should help with the issue #85826
2024-03-19 21:01:15 -04:00
emild d88df641ee Fix snapping multiple keys in Animation 2024-03-18 11:21:12 +01:00
Haoyu Qiu 8cd1ebbd6d Fix unexpected auto translation of Tree content 2024-03-18 09:31:00 +08:00
Muller-Castro 1638c1b28f Add const lvalue ref to editor/* container parameters 2024-02-26 15:28:15 -03:00
Rémi Verschelde 6037500219
Merge pull request #69032 from KoBeWi/check_every_changed_setting_in_every_group_everywhere()
Use `check_changed_settings_in_group()` everywhere
2024-02-20 19:34:30 +01:00
emild 041315253f Fix various bugs in Animation key right click actions 2024-02-20 12:17:20 +01:00
kobewi a031911c82 Use check_changed_settings_in_group() everywhere 2024-02-19 21:34:45 +01:00
CookieBadger 47dba6bc56 use ED_IS_SHORTCUT macro instead of matches_event 2024-02-19 13:16:06 +01:00
Rémi Verschelde 7bc2605f02
Merge pull request #88436 from AThousandShips/editor_ellipses
[Editor] Add missing ellipses to menu options that open dialogs
2024-02-18 11:23:48 +01:00
Rémi Verschelde 4002ea7e15
Merge pull request #88350 from CookieBadger/animation-cut-keyframe
Implement Cut Selected Keys in AnimationPlayer
2024-02-18 11:23:41 +01:00
A Thousand Ships fc3a2933de
Fix crash with animation audio track offset 2024-02-17 17:42:45 +01:00
A Thousand Ships dde5368dee
[Editor] Add missing ellipses to menu options that open dialogs 2024-02-17 17:09:17 +01:00
Silc Lizard (Tokage) Renew 4659090543 Make consistent the retrieval of audio tracks 2024-02-18 00:15:33 +09:00
Rémi Verschelde 2c5fa95aea
Merge pull request #87530 from YeldhamDev/atr_inheritance
Rework the auto translation system
2024-02-17 15:54:31 +01:00
Rémi Verschelde b6ef996eb7
Merge pull request #86608 from TokageItLab/add-warn-setting-anim
Add some options to Project Settings to silence warnings in AnimationMixer caching
2024-02-17 00:22:52 +01:00
Michael Alexsander 7b42c24550
Make auto translation inheritable 2024-02-15 16:51:19 -03:00
Rémi Verschelde b8a402b3cb
Merge pull request #88352 from CookieBadger/bezier-handle-mode-undo-fix
Fix Bezier Editor HandleMode UndoRedo History mismatch
2024-02-15 15:45:27 +01:00