godotengine
/
godot
mirror of https://github.com/godotengine/godot
1
0
Fork 0
Code
69,024 Commits 19 Branches 65 Tags 4.7 GiB
Commit Graph

671 Commits

Author SHA1 Message Date
Thaddeus Crews 323b2d53d7
Merge pull request #98963 from RandomShaper/fix_classdb_deadlock 
Fix deadlocks related to ClassDB queries about global classes
 2024-11-10 12:12:24 -06:00
Pedro J. Estébanez 56bdef9f6f Fix deadlocks related to ClassDB queries about global classes 
`ClassDB::can_instantiate()` and other reflection methods deadlock if the type is an script global class, when such script indirectly uses a not-yet-registered class. The reason is the `ClassDB` read lock is still held when invoking the `ResourceLoader` to load the class script, which may in turn need to lock for writing (for the class registration).

In particular, this happens with some types related to animation tree, that aren't registered at engine startup, but can happen with others, especially ones from the user. Registration statements are also added for the animation-related types that were lacking them.
 2024-11-08 18:15:58 +01:00
Thaddeus Crews bb5f390fb9
Style: Apply `clang-tidy` fixes (superficial) 
• `modernize-use-bool-literals`, `modernize-use-nullptr`, and `readability-braces-around-statements`
 2024-11-04 12:11:14 -06:00
A Thousand Ships 38f9769bc6
[Core] Improve error messages with `vformat` 2024-10-30 15:55:51 +01:00
Adam Scott 0d350e7108
Set clang-format `RemoveSemicolon` rule to `true` 
- Set clang-format `Standard` rule to `c++20`
 2024-10-25 13:49:43 -04:00
Rémi Verschelde 9ce149c7a3
Merge pull request #93299 from rune-scape/fix-ref 
Fix RefCounted releasing early and not clearing reference
 2024-10-02 15:00:47 +02:00
Danil Alexeev 85dfd89653 Add `@export_tool_button` annotation for easily creating inspector buttons 
Co-authored-by: jordi <creptthrust@gmail.com>
Co-authored-by: K. S. Ernest (iFire) Lee <ernest.lee@chibifire.com>
Co-authored-by: Mack <86566939+Macksaur@users.noreply.github.com>
 2024-09-27 22:24:15 +01:00
Rémi Verschelde 8a9a26ef19
Merge pull request #93311 from dsnopek/gdextension-required-virtuals 
GDExtension: Mark virtual function as `is_required` in `extension_api.json`
 2024-09-27 13:53:16 +02:00
Rémi Verschelde 9d5b59b2ae
Merge pull request #94864 from rune-scape/add-missing-method-bind 
Add missing CallableCustomMethodPointer for const methods
 2024-09-26 12:45:27 +02:00
Thaddeus Crews 9f9ee0c813
SCons: Add unobtrusive type hints in SCons files 2024-09-25 09:34:35 -05:00
kobewi 7aef30c2a8 Discard additional redo on commiting actions 2024-09-24 15:47:55 +02:00
rune-scape a84c480049 Add missing CallableCustomMethodPointer for const methods 2024-09-23 11:46:10 -07:00
rune-scape cee0e6667a Refactor ref-counting code and fix ref counted releasing before aquiring 2024-09-21 11:36:58 -07:00
Rémi Verschelde dd7cb059f5
Merge pull request #87344 from AThousandShips/signal_connected 
[Core] Add way to check if a signal has any connections
 2024-09-21 11:50:24 +02:00
Rémi Verschelde 621cadcf65
Merge pull request #97168 from Hilderin/fix-reloading-scripts-already-in-use 
Fix reloading scripts already in use
 2024-09-20 21:35:08 +02:00
Hilderin 9638220473 Fix reloading scripts already in use 2024-09-20 12:12:24 -04:00
A Thousand Ships 203d3be200
[Core] Add way to check if a signal has any connections 
Added to `Object` and `Signal`
 2024-09-20 16:39:09 +02:00
Haoyu Qiu 818acb4290 Make editor use translation domains 
How editor plugins use this feature:
1. Pick a unique translation domain name.
2. `_enter_tree()`: load translations into that translation domain.
3. Call `set_translation_domain()` for its root UI node.
4. `_exit_tree()`: remove that translation domain.

Plugins can also set the translation domain to `godot.editor` for
nested nodes that should use editor translations. `EditorFileDialog`
automatically does this.
 2024-09-17 13:09:44 +08:00
Haoyu Qiu c5d147b9b5 Allow configuring which translation domain Object.tr uses 2024-09-17 13:09:44 +08:00
Clay John 48403b5358
Merge pull request #96959 from RandomShaper/revamp_languages_exit 
WorkerThreadPool: Revamp interaction with ScriptServer
 2024-09-16 16:05:57 -07:00
Pedro J. Estébanez 5d371e3378 WorkerThreadPool: Add safety point between languages finished and pool termination 2024-09-16 18:20:10 +02:00
Pedro J. Estébanez 2a483fa9ba WorkerThreadPool: Refactor running and exit-requested as runlevels 2024-09-16 18:06:22 +02:00
Pedro J. Estébanez 2640960706 WorkerThreadPool: Improve logic 
- The main thread function and the collaborative wait functions have a much more similar structure than earlier, which yields (pun intended) better maintainability.
- Also, there are not assertions anymore about the reason for ending a wait being valid, because spurious awakes can happen and so the assert would fail without that indicating an issue.
 2024-09-16 18:03:36 +02:00
Rémi Verschelde f7daa0fb2f
Merge pull request #96856 from RandomShaper/selfdestruct_correctness 
Object: Let debug lock handle callee destruction within call chain gracefully
 2024-09-16 13:35:06 +02:00
Rémi Verschelde 8ebfd89359
Merge pull request #96024 from Ryan-000/expose_get_rpc_config 
Expose `get_rpc_config` and `get_node_rpc_config`
 2024-09-16 13:34:34 +02:00
Pedro J. Estébanez e2fd88ed91 Revert "WorkerThreadPool: Enhance lifetime for more flexibility" 
This reverts commit 2d1dd41ef5.
 2024-09-13 14:39:11 +02:00
A Thousand Ships df29cc696f
[Core] Optionally delete `Ref` `nullptr` comparisons 
Adds an optional (default false) compile option to enable comparing
`Ref` to `nullptr` to ensure correct use, as well as future expandsion
for more general dev checks (enabled with `dev_mode`)
 2024-09-12 11:26:49 +02:00
Rémi Verschelde 23e51c3cb5
Merge pull request #92888 from Hilderin/fix-unable-to-use-resourceLoader-in-c#-after-threaded-load 
Fix inability to use ResourceLoader in C# after threaded load in GDScript
 2024-09-12 09:25:05 +02:00
Rémi Verschelde cd9da3344f
Merge pull request #95292 from aaronp64/is_parent_class_perf 
Improve `ClassDB::_is_parent_class` performance
 2024-09-12 09:17:39 +02:00
Pedro J. Estébanez 10e2318bde Object: Let debug lock handle callee destruction within call chain gracefully 
Co-authored-by: lawnjelly <lawnjelly@gmail.com>
 2024-09-12 08:51:24 +02:00
Hilderin 27d1fb63e1 Fix Unable to use ResourceLoader in C# after threaded load in GDScript #92798 2024-09-11 19:03:55 -04:00
David Snopek c2af6bcb59 GDExtension: Mark virtual function as `is_required` in `extension_api.json` 
Co-authored-by: Jovan Gerodetti <jovan.gerodetti@titannano.de>
 2024-09-11 16:48:14 -05:00
Rémi Verschelde 658b8a8704
Merge pull request #96760 from RandomShaper/wtp_langs_exit_thread 
Make use of languages' thread enter/exit more correct
 2024-09-11 12:35:07 +02:00
Pedro J. Estébanez c8acf561ef Make languages' thread enter/exit more resilient 2024-09-10 17:22:32 +02:00
Pedro J. Estébanez 2d1dd41ef5 WorkerThreadPool: Enhance lifetime for more flexibility 2024-09-10 11:08:51 +02:00
rune-scape 0dde931bc9 StringName: Fix empty hash 
+Fixed compat hashes
 2024-09-09 13:30:02 -07:00
Rémi Verschelde 0b4ae20156
Merge pull request #78656 from Repiteo/typed-dictionary 
Implement typed dictionaries
 2024-09-06 22:38:13 +02:00
Rémi Verschelde 58b3481eaf
Merge pull request #89649 from dalexeev/core-bind-and-doc-iter-virtual-methods 
Core: Bind and document iterator API virtual methods
 2024-09-06 11:10:58 +02:00
Ryan 8835f326b1 Expose get_rpc_config and get_node_rpc_config 
add documentation

Update doc/classes/Node.xml

change name of get_node_rpc_config to get_rpc_config

Co-Authored-By: moondog <159832633+dog-on-moon@users.noreply.github.com>
Co-Authored-By: Micky <66727710+Mickeon@users.noreply.github.com>
 2024-09-04 15:45:22 -04:00
Thaddeus Crews 9853a69144
Implement typed dictionaries 2024-09-04 10:27:26 -05:00
Rémi Verschelde 13a90e938f
Merge pull request #70096 from rune-scape/stringname-dict 
StringName Dictionary keys
 2024-09-03 17:38:06 +02:00
Jan Haller 82b2a58f4c Fix `bool` type appearing in GDExtension header 2024-08-31 22:40:48 +02:00
Rémi Verschelde 4c0ce657d5
Merge pull request #96322 from RandomShaper/wtp_info 
WorkerThreadPool: Print info about thread count at startup
 2024-08-30 23:37:58 +02:00
Danil Alexeev 49bcdf78a7
Core: Сheck `r_error` after calling `callp()` 2024-08-30 21:09:30 +03:00
Pedro J. Estébanez db4672f83f WorkerThreadPool: Print info about thread count at startup 2024-08-30 13:04:46 +02:00
Rémi Verschelde a5830f6eb9
Merge pull request #96317 from Chaosus/objectdb_write_path_instead_of_name_at_cleanup 
Write path instead of name at verbose output of leaked instances
 2024-08-30 11:43:13 +02:00
Rémi Verschelde 909629d9f9
Merge pull request #96166 from AThousandShips/more_lock_raii 
Use `MutexLock` in more places
 2024-08-30 09:59:19 +02:00
Rémi Verschelde f0ee0bdd37
Merge pull request #93972 from Hilderin/fix-editor-needs-restart-after-adding-gdextensions 
Fix editor needs restart after adding GDExtensions
 2024-08-30 09:59:05 +02:00
Chaosus 75055a8278 Write path instead of name at verbose output of leaked instances 2024-08-30 10:58:50 +03:00
rune-scape 154049ce17 StringName Dictionary keys 
also added 'is_string()' method to Variant
and refactored many String type comparisons to use it instead
 2024-08-29 13:39:27 -07:00