godotengine
/
godot
mirror of https://github.com/godotengine/godot
1
0
Fork 0
Code

Fix file handle leak in ZipArchive and FileAccessZip

This commit is contained in:
Mateo "Kuruk" Miccino 2025-02-23 10:25:34 -03:00
parent 0e3dbba6a5
commit d8b09c4757
No known key found for this signature in database
GPG Key ID: 550EB868BE3F3ADA
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/io/file_access_zip.cpp
View File

@ -176,7 +176,6 @@ bool ZipArchive::try_open_pack(const String &p_path, bool p_replace_files, uint6
Package pkg;
pkg.filename = p_path;
pkg.zfile = zfile;
packages.push_back(pkg);
int pkg_num = packages.size() - 1;
@ -203,6 +202,8 @@ bool ZipArchive::try_open_pack(const String &p_path, bool p_replace_files, uint6
}
}
unzClose(zfile);
return true;
}
@ -227,10 +228,6 @@ ZipArchive::ZipArchive() {
}
ZipArchive::~ZipArchive() {
for (int i = 0; i < packages.size(); i++) {
unzClose(packages[i].zfile);
}
packages.clear();
}

1
core/io/file_access_zip.h
View File

@ -48,7 +48,6 @@ public:
private:
struct Package {
String filename;
unzFile zfile = nullptr;
};
Vector<Package> packages;