godotengine
/
godot
mirror of https://github.com/godotengine/godot
1
0
Fork 0
Code

Merge pull request #100174 from Calinou/gdscript-add-deprecated-experimental-annotations 

Tweak unknown annotation GDScript error for `@deprecated`/`@experimental`/`@tutorial`
This commit is contained in:
Thaddeus Crews 2024-12-11 17:35:50 -06:00
parent be65514c11 6095a37d64
commit ab208af781
No known key found for this signature in database
GPG Key ID: 62181B86FE9E5D84
7 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
modules/gdscript/gdscript_parser.cpp
View File

@ -1637,7 +1637,15 @@ GDScriptParser::AnnotationNode *GDScriptParser::parse_annotation(uint32_t p_vali
bool valid = true;
if (!valid_annotations.has(annotation->name)) {
push_error(vformat(R"(Unrecognized annotation: "%s".)", annotation->name));
if (annotation->name == "@deprecated") {
push_error(R"("@deprecated" annotation does not exist. Use "## @deprecated: Reason here." instead.)");
} else if (annotation->name == "@experimental") {
push_error(R"("@experimental" annotation does not exist. Use "## @experimental: Reason here." instead.)");
} else if (annotation->name == "@tutorial") {
push_error(R"("@tutorial" annotation does not exist. Use "## @tutorial(Title): https://example.com" instead.)");
} else {
push_error(vformat(R"(Unrecognized annotation: "%s".)", annotation->name));
}
valid = false;
}

5
modules/gdscript/tests/scripts/parser/errors/annotation_deprecated.gd Normal file
View File

@ -0,0 +1,5 @@
# This annotation should be used within a documentation comment instead:
# ## @deprecated: Reason here.
@deprecated
var some_variable = "value"

2
modules/gdscript/tests/scripts/parser/errors/annotation_deprecated.out Normal file
View File

@ -0,0 +1,2 @@
GDTEST_PARSER_ERROR
"@deprecated" annotation does not exist. Use "## @deprecated: Reason here." instead.

6
modules/gdscript/tests/scripts/parser/errors/annotation_experimental.gd Normal file
View File

@ -0,0 +1,6 @@
# This annotation should be used within a documentation comment instead:
# ## @experimental: Reason here.
@experimental("This function isn't implemented yet.")
func say_hello():
pass

2
modules/gdscript/tests/scripts/parser/errors/annotation_experimental.out Normal file
View File

@ -0,0 +1,2 @@
GDTEST_PARSER_ERROR
"@experimental" annotation does not exist. Use "## @experimental: Reason here." instead.

5
modules/gdscript/tests/scripts/parser/errors/annotation_tutorial.gd Normal file
View File

@ -0,0 +1,5 @@
# This annotation should be used within a documentation comment instead:
# ## @tutorial(Title): https://example.com
@tutorial("https://example.com")
const SOME_CONSTANT = "value"

2
modules/gdscript/tests/scripts/parser/errors/annotation_tutorial.out Normal file
View File

@ -0,0 +1,2 @@
GDTEST_PARSER_ERROR
"@tutorial" annotation does not exist. Use "## @tutorial(Title): https://example.com" instead.