godotengine
/
godot
mirror of https://github.com/godotengine/godot
1
0
Fork 0
Code

Make loading translations from threads safe

This commit is contained in:
Pedro J. Estébanez 2024-11-22 09:44:07 +01:00
parent 9e6098432a
commit 7a25173ff4
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/string/translation.cpp
View File

@ -80,8 +80,10 @@ void Translation::set_locale(const String &p_locale) {
if (Thread::is_main_thread()) { if (Thread::is_main_thread()) {
_notify_translation_changed_if_applies(); _notify_translation_changed_if_applies();
} else { } else {
// Avoid calling non-thread-safe functions here. // This has to happen on the main thread (bypassing the ResourceLoader per-thread call queue)
callable_mp(this, &Translation::_notify_translation_changed_if_applies).call_deferred(); // because it interacts with the generally non-thread-safe window management, leading to
// different issues across platforms otherwise.
MessageQueue::get_main_singleton()->push_callable(callable_mp(this, &Translation::_notify_translation_changed_if_applies));
} }
} }