godotengine
/
godot
mirror of https://github.com/godotengine/godot
1
0
Fork 0
Code

Save LightmapGI shadowmask to a lossless WebP image to reduce file size 

This doesn't affect the size of the exported project (which uses
a VRAM-compressed copy by default), but it reduces the size of the files
that are committed to version control or included within MRP ZIPs.

When you iterate on lightmaps frequently and commit new versions of them,
this can add up to saving dozens if not hundreds of megabytes over time.

This change is fully backwards-compatible and forwards-compatible
with existing projects that use PNG shadowmask textures, as the shadowmask
path is saved in LightmapGIData.
This commit is contained in:
Hugo Locurcio 2025-01-21 17:34:42 +01:00
parent 1b7b009674
commit 1b0c21fc87
No known key found for this signature in database
GPG Key ID: 39E8F8BE30B0A49C
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
scene/3d/lightmap_gi.cpp
View File

@ -834,7 +834,7 @@ LightmapGI::BakeError LightmapGI::_save_and_reimport_atlas_textures(const Ref<Li
texture_image->blit_rect(images[i * slices_per_texture + j], Rect2i(0, 0, slice_width, slice_height), Point2i(0, slice_height * j));
}
const String atlas_path = (texture_count > 1 ? p_base_name + "_" + itos(i) : p_base_name) + (p_is_shadowmask ? ".png" : ".exr");
const String atlas_path = (texture_count > 1 ? p_base_name + "_" + itos(i) : p_base_name) + (p_is_shadowmask ? ".webp" : ".exr");
const String config_path = atlas_path + ".import";
Ref<ConfigFile> config;
@ -865,7 +865,19 @@ LightmapGI::BakeError LightmapGI::_save_and_reimport_atlas_textures(const Ref<Li
// Save the file.
Error save_err;
if (p_is_shadowmask) {
save_err = texture_image->save_png(atlas_path);
// Downsize the image if needed to fit within the WebP format limitations.
// In practice, the maximum usable texture size is typically 16384×16384,
// so this only changes the size by 1 pixel which is unnoticeable.
constexpr int WEBP_SIZE_LIMIT = 16383;
if (texture_image->get_width() > WEBP_SIZE_LIMIT) {
texture_image->resize(WEBP_SIZE_LIMIT, texture_image->get_height() * WEBP_SIZE_LIMIT / texture_image->get_width());
} else if (texture_image->get_height() > WEBP_SIZE_LIMIT) {
texture_image->resize(texture_image->get_width() * WEBP_SIZE_LIMIT / texture_image->get_height(), WEBP_SIZE_LIMIT);
}
// Save as lossless WebP instead of PNG to reduce file size in the project files.
// The exported project size will remain identical, but this reduces the size of the file
// that is committed to version control.
save_err = texture_image->save_webp(atlas_path);
} else {
save_err = texture_image->save_exr(atlas_path, false);
}