From 06bb9944d7a041bc4d5b8fba72ad36aa6e9e27ae Mon Sep 17 00:00:00 2001 From: Micky Date: Wed, 27 Nov 2024 01:39:16 +0100 Subject: [PATCH] Fix code consistency between AudioStreamPlayer2D and AudioStreamPlayer3D --- scene/3d/audio_stream_player_3d.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/scene/3d/audio_stream_player_3d.cpp b/scene/3d/audio_stream_player_3d.cpp index eb75650399d..15201b6c5a5 100644 --- a/scene/3d/audio_stream_player_3d.cpp +++ b/scene/3d/audio_stream_player_3d.cpp @@ -553,7 +553,7 @@ void AudioStreamPlayer3D::play(float p_from_pos) { setplay.set(p_from_pos); // Sample handling. - if (stream_playback->get_is_sample()) { + if (stream_playback->get_is_sample() && stream_playback->get_sample_playback().is_valid()) { Ref sample_playback = stream_playback->get_sample_playback(); sample_playback->offset = p_from_pos; sample_playback->bus = _get_actual_bus(); @@ -563,10 +563,7 @@ void AudioStreamPlayer3D::play(float p_from_pos) { } void AudioStreamPlayer3D::seek(float p_seconds) { - if (is_playing()) { - stop(); - play(p_seconds); - } + internal->seek(p_seconds); } void AudioStreamPlayer3D::stop() {